Skip to content

Commit ac5acd2

Browse files
committed
use canonical function arg name comment format as per Jakub's suggestion
1 parent 37f2296 commit ac5acd2

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -444,9 +444,10 @@ createSubgroupDPPReduction(PatternRewriter &rewriter, gpu::SubgroupReduceOp op,
444444
// for an illustration of how this within-cluster broadcast works with a
445445
// swizzle.
446446
if (ci.subgroupSize == 64 && ci.clusterSize == 32) {
447-
res = amdgpu::SwizzleBitModeOp::create(rewriter, loc, res, /*and*/ 0,
448-
/*or*/ 31,
449-
/*xor*/ 0);
447+
res =
448+
amdgpu::SwizzleBitModeOp::create(rewriter, loc, res, /*and_mask=*/0,
449+
/*or_mask=*/31,
450+
/*xor_mask=*/0);
450451
}
451452
} else if (chipset.majorVersion <= 12) {
452453
// Use a permute lane to cross rows (row 1 <-> row 0, row 3 <-> row 2).

0 commit comments

Comments
 (0)