remove custom deleter and use out of line definitions

Author: optimisan

llvm/include/llvm/CodeGen/SpillPlacement.h

@@ -52,8 +52,7 @@ class SpillPlacement {
   const EdgeBundles *bundles = nullptr;
   const MachineBlockFrequencyInfo *MBFI = nullptr;
 
-  static void arrayDeleter(Node *N);
-  std::unique_ptr<Node[], decltype(&arrayDeleter)> nodes;
+  std::unique_ptr<Node[]> nodes;
 
   // Nodes that are active in the current computation. Owned by the prepare()
   // caller.
@@ -161,13 +160,15 @@ class SpillPlacement {
   bool invalidate(MachineFunction &MF, const PreservedAnalyses &PA,
                   MachineFunctionAnalysisManager::Invalidator &Inv);
 
+  // Move the default definitions to the implementation
+  // so the full definition of Node is available.
+  SpillPlacement(SpillPlacement &&);
+  ~SpillPlacement();
+
 private:
-  SpillPlacement() : nodes(nullptr, &arrayDeleter) {};
+  SpillPlacement();
 
-  void releaseMemory() {
-    nodes.reset();
-    TodoList.clear();
-  }
+  void releaseMemory();
 
   void run(MachineFunction &MF, EdgeBundles *Bundles,
            MachineBlockFrequencyInfo *MBFI);

llvm/lib/CodeGen/SpillPlacement.cpp

@@ -219,9 +219,13 @@ bool SpillPlacementAnalysis::Result::invalidate(
          Inv.invalidate<MachineBlockFrequencyAnalysis>(MF, PA);
 }
 
-void SpillPlacement::arrayDeleter(Node *N) {
-  if (N)
-    delete[] N;
+SpillPlacement::SpillPlacement() = default;
+SpillPlacement::~SpillPlacement() = default;
+SpillPlacement::SpillPlacement(SpillPlacement &&) = default;
+
+void SpillPlacement::releaseMemory() {
+  nodes.reset();
+  TodoList.clear();
 }
 
 void SpillPlacement::run(MachineFunction &mf, EdgeBundles *Bundles,