Skip to content

Commit ad26777

Browse files
committed
fixup: add documentation justifying the serialization test
1 parent e3c44b4 commit ad26777

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

mlir/test/Conversion/VectorToLLVM/pass-option-serialization.mlir

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
1-
// Simple regression test that ensures ConvertVectorToLLVMPass options remain
2-
// serialisable. We don't need to actually parse any IR to print the pass
3-
// options. We just need to provide --dump-pass-pipeline
1+
// Ensure that ConvertVectorToLLVMPass options remain serialisable.
2+
3+
// This test also allows us to exercise these options (to some extent) even if we
4+
// don't use them in other Vector to LLVM conversion tests. This is quite relevant
5+
// for the `Vector` Dialect (and `--convert-vector-to-llvm` pass) as in many cases
6+
// we use the Transform Dialect (TD) rather than `--convert-vector-to-llvm` for
7+
// testing. So here we don't check the correctness of the passes, as they're
8+
// covered by other tests that use TD, but we still provide some test coverage of
9+
// these pass options.
10+
11+
// We don't need to actually parse any IR to print the pass options. We just need
12+
// to provide --dump-pass-pipeline
413

514
// RUN: mlir-opt --convert-vector-to-llvm --dump-pass-pipeline %s 2>&1 | FileCheck %s --check-prefix=DEFAULT
615

0 commit comments

Comments
 (0)