[lldb] Give a new dump command a clearer name

Author: Mikhail Zakharov

lldb/source/Commands/CommandObjectProcess.cpp

@@ -1827,16 +1827,17 @@ class CommandObjectMultiwordProcessTrace : public CommandObjectMultiword {
   ~CommandObjectMultiwordProcessTrace() override = default;
 };
 
-// CommandObjectProcessDumpModId
-class CommandObjectProcessDumpModId : public CommandObjectParsed {
+// CommandObjectProcessDumpModificationId
+class CommandObjectProcessDumpModificationId : public CommandObjectParsed {
 public:
-  CommandObjectProcessDumpModId(CommandInterpreter &interpreter)
-      : CommandObjectParsed(interpreter, "process dump-mod-id",
+  CommandObjectProcessDumpModificationId(CommandInterpreter &interpreter)
+      : CommandObjectParsed(interpreter, "process dump-modification-id",
                             "Dump the state of the ProcessModID. Intended to "
                             "be used for debugging LLDB itself.",
-                            "process dump-mod-id", eCommandRequiresProcess) {}
+                            "process dump-modification-id",
+                            eCommandRequiresProcess) {}
 
-  ~CommandObjectProcessDumpModId() override = default;
+  ~CommandObjectProcessDumpModificationId() override = default;
 
 protected:
   void DoExecute(Args &command, CommandReturnObject &result) override {
@@ -1893,8 +1894,8 @@ CommandObjectMultiwordProcess::CommandObjectMultiwordProcess(
       "trace",
       CommandObjectSP(new CommandObjectMultiwordProcessTrace(interpreter)));
   LoadSubCommand(
-      "dump-mod-id",
-      CommandObjectSP(new CommandObjectProcessDumpModId(interpreter)));
+      "dump-modification-id",
+      CommandObjectSP(new CommandObjectProcessDumpModificationId(interpreter)));
 }
 
 CommandObjectMultiwordProcess::~CommandObjectMultiwordProcess() = default;

…st/Shell/Expr/TestProcessModIdOnExpr.cpp …Expr/TestProcessModificationIdOnExpr.cpplldb/test/Shell/Expr/TestProcessModIdOnExpr.cpp renamed to lldb/test/Shell/Expr/TestProcessModificationIdOnExpr.cpp lldb/test/Shell/Expr/TestProcessModIdOnExpr.cpp renamed to lldb/test/Shell/Expr/TestProcessModificationIdOnExpr.cpp

@@ -7,15 +7,15 @@
 // RUN: %lldb %t \
 // RUN:   -o "settings set target.process.track-memory-cache-changes false" \
 // RUN:   -o "run" \
-// RUN:   -o "process dump-mod-id" \
+// RUN:   -o "process dump-modification-id" \
 // RUN:   -o "expr x.i != 42" \
-// RUN:   -o "process dump-mod-id" \
+// RUN:   -o "process dump-modification-id" \
 // RUN:   -o "expr x.get()" \
-// RUN:   -o "process dump-mod-id" \
+// RUN:   -o "process dump-modification-id" \
 // RUN:   -o "expr x.i = 10" \
-// RUN:   -o "process dump-mod-id" \
+// RUN:   -o "process dump-modification-id" \
 // RUN:   -o "continue" \
-// RUN:   -o "process dump-mod-id" \
+// RUN:   -o "process dump-modification-id" \
 // RUN:   -o "exit" | FileCheck %s -dump-input=fail
 
 class X {
@@ -34,34 +34,34 @@ int main() {
   return 0;
 }
 
-// CHECK-LABEL: process dump-mod-id
+// CHECK-LABEL: process dump-modification-id
 // CHECK: m_stop_id: 2
 // CHECK: m_memory_id: 0
 
 // CHECK-LABEL: expr x.i != 42
 // IDs are not changed when executing simple expressions
 
-// CHECK-LABEL: process dump-mod-id
+// CHECK-LABEL: process dump-modification-id
 // CHECK: m_stop_id: 2
 // CHECK: m_memory_id: 0
 
 // CHECK-LABEL: expr x.get()
 // Expression causes ID to be bumped because LLDB has to execute function
 
-// CHECK-LABEL: process dump-mod-id
+// CHECK-LABEL: process dump-modification-id
 // CHECK: m_stop_id: 3
 // CHECK: m_memory_id: 1
 
 // CHECK-LABEL: expr x.i = 10
 // Expression causes MemoryID to be bumped because LLDB writes to non-cache memory
 
-// CHECK-LABEL: process dump-mod-id
+// CHECK-LABEL: process dump-modification-id
 // CHECK: m_stop_id: 3
 // CHECK: m_memory_id: 2
 
 // CHECK-LABEL: continue
 // Continue causes StopID to be bumped because process is resumed
 
-// CHECK-LABEL: process dump-mod-id
+// CHECK-LABEL: process dump-modification-id
 // CHECK: m_stop_id: 4
 // CHECK: m_memory_id: 2