Remove MCSA_WeakReference/MCSA_Global from the loop

Author: redstar

llvm/include/llvm/MC/MCSymbolGOFF.h

@@ -63,9 +63,10 @@ class MCSymbolGOFF : public MCSymbol {
   GOFF::ESDLinkageType getLinkage() const { return Linkage; }
 
   GOFF::ESDBindingScope getBindingScope() const {
-    return isExternal() ? (isExported() ? GOFF::ESD_BSC_ImportExport
-                                        : GOFF::ESD_BSC_Library)
-                        : GOFF::ESD_BSC_Section;
+    return (isExternal() || !isDefined()) ? isExported()
+                                                ? GOFF::ESD_BSC_ImportExport
+                                                : GOFF::ESD_BSC_Library
+                                          : GOFF::ESD_BSC_Section;
   }
 
   GOFF::ESDBindingStrength getBindingStrength() const {

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

@@ -2942,9 +2942,6 @@ bool AsmPrinter::doFinalization(Module &M) {
     for (auto &GO : M.global_objects()) {
       if (GO.isDeclaration()) {
         MCSymbol *Sym = TM.getSymbol(&GO);
-        OutStreamer->emitSymbolAttribute(Sym, GO.hasExternalWeakLinkage()
-                                                  ? MCSA_WeakReference
-                                                  : MCSA_Global);
         OutStreamer->emitSymbolAttribute(Sym, isa<Function>(GO)
                                                   ? MCSA_ELF_TypeFunction
                                                   : MCSA_ELF_TypeObject);

llvm/lib/MC/MCAsmInfoGOFF.cpp

@@ -22,6 +22,7 @@ using namespace llvm;
 MCAsmInfoGOFF::MCAsmInfoGOFF() {
   Data64bitsDirective = "\t.quad\t";
   HasDotTypeDotSizeDirective = false;
+  WeakRefDirective = "WXTRN";
   PrivateGlobalPrefix = "L#";
   PrivateLabelPrefix = "L#";
   ZeroDirective = "\t.space\t";

llvm/lib/MC/MCSymbolGOFF.cpp

@@ -27,6 +27,7 @@ bool MCSymbolGOFF::setSymbolAttribute(MCSymbolAttr Attribute) {
   case MCSA_IndirectSymbol:
   case MCSA_Internal:
   case MCSA_LazyReference:
+  case MCSA_Local:
   case MCSA_NoDeadStrip:
   case MCSA_SymbolResolver:
   case MCSA_AltEntry:
@@ -54,9 +55,6 @@ bool MCSymbolGOFF::setSymbolAttribute(MCSymbolAttr Attribute) {
   case MCSA_Global:
     setExternal(true);
     break;
-  case MCSA_Local:
-    setExternal(false);
-    break;
   case MCSA_Weak:
   case MCSA_WeakReference:
     setExternal(true);