insert_range.pass.cpp, empty passes, stuck at next

Author: vinay-deshmukh

libcxx/include/__tree

@@ -1652,7 +1652,14 @@ __tree<_Tp, _Compare, _Allocator>::operator=(__tree&& __t)
 template <class _Tp, class _Compare, class _Allocator>
 _LIBCPP_CONSTEXPR_SINCE_CXX26 __tree<_Tp, _Compare, _Allocator>::~__tree() {
   static_assert(is_copy_constructible<value_compare>::value, "Comparator must be copy-constructible.");
-  destroy(__root());
+  // TODO: get this verified
+  // without this check, constexpr evaluation goes into infinite recursion, for 
+  // insert_range.pass.cpp:EmptyContainer_EmptyRange
+
+  // not sure if this is UB ?, if not, we need to add is_constant_evaluated()
+  if(size() > 0) {
+    destroy(__root());
+  }
 }
 
 template <class _Tp, class _Compare, class _Allocator>

libcxx/test/std/containers/associative/map/map.modifiers/insert_range.pass.cpp

@@ -9,6 +9,7 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 // Some fields in the test case variables are deliberately not explicitly initialized, this silences a warning on GCC.
 // ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-missing-field-initializers
+// ADDITIONAL_COMPILE_FLAGS: -fconstexpr-backtrace-limit=5 -fconstexpr-depth=120000
 
 // <map>
 

libcxx/test/std/containers/insert_range_maps_sets.h

@@ -200,7 +200,7 @@ TestCaseMapSet<std::pair<K, V>> constexpr NElementsContainer_RangeWithDuplicates
         {16, 'D'}}};
 
 template <class Container, class T, class Iter, class Sent>
-void test_map_set_insert_range(bool allow_duplicates = false) {
+TEST_CONSTEXPR_CXX26 void test_map_set_insert_range(bool allow_duplicates = false) {
   auto test = [&](const TestCaseMapSet<T>& test_case, bool check_multi = false) {
     Container c(test_case.initial.begin(), test_case.initial.end());
     auto in = wrap_input<Iter, Sent>(test_case.input);