Added testcase for GetProgramFileSpec & FindProcesses

Author: HemangGadhavi

lldb/source/Host/aix/Host.cpp

@@ -42,14 +42,6 @@ static ProcessInstanceInfo::timespec convert(pr_timestruc64_t t) {
   return ts;
 }
 
-static bool IsDirNumeric(const char *dname) {
-  for (; *dname; dname++) {
-    if (!isdigit(*dname))
-      return false;
-  }
-  return true;
-}
-
 static bool GetStatusInfo(::pid_t pid, ProcessInstanceInfo &processInfo,
                           ProcessState &State) {
   struct pstatus pstatusData;
@@ -152,10 +144,10 @@ uint32_t Host::FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
     bool all_users = match_info.GetMatchAllUsers();
 
     while ((direntry = readdir(dirproc)) != nullptr) {
-      if (!IsDirNumeric(direntry->d_name))
+      lldb::pid_t pid;
+      // Skip non-numeric name directories
+      if (!llvm::to_integer(direntry->d_name, pid))
         continue;
-
-      lldb::pid_t pid = atoi(direntry->d_name);
       // Skip this process.
       if (pid == our_pid)
         continue;
@@ -174,9 +166,8 @@ uint32_t Host::FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
       if (!all_users && (our_uid != 0) && (process_info.GetUserID() != our_uid))
         continue;
 
-      if (match_info.Matches(process_info)) {
+      if (match_info.Matches(process_info))
         process_infos.push_back(process_info);
-      }
     }
     closedir(dirproc);
   }

lldb/source/Host/aix/HostInfoAIX.cpp

@@ -29,9 +29,8 @@ FileSpec HostInfoAIX::GetProgramFileSpec() {
     llvm::StringRef exe_path(
         psinfoData.pr_psargs,
         strnlen(psinfoData.pr_psargs, sizeof(psinfoData.pr_psargs)));
-    if (!exe_path.empty()) {
+    if (!exe_path.empty())
       g_program_filespec.SetFile(exe_path, FileSpec::Style::native);
-    }
   }
   return g_program_filespec;
 }

lldb/unittests/Host/HostInfoTest.cpp

@@ -54,6 +54,11 @@ TEST_F(HostInfoTest, GetHostname) {
   EXPECT_TRUE(HostInfo::GetHostname(s));
 }
 
+TEST_F(HostInfoTest, GetProgramFileSpec) {
+  FileSpec filespec = HostInfo::GetProgramFileSpec();
+  EXPECT_TRUE(FileSystem::Instance().Exists(filespec));
+}
+
 #if defined(__APPLE__)
 TEST_F(HostInfoTest, GetXcodeSDK) {
   auto get_sdk = [](std::string sdk, bool error = false) -> llvm::StringRef {

lldb/unittests/Host/HostTest.cpp

@@ -9,6 +9,7 @@
 #include "lldb/Host/Host.h"
 #include "TestingSupport/SubsystemRAII.h"
 #include "lldb/Host/FileSystem.h"
+#include "lldb/Host/HostInfo.h"
 #include "lldb/Host/Pipe.h"
 #include "lldb/Host/ProcessLaunchInfo.h"
 #include "lldb/Utility/ProcessInfo.h"
@@ -90,6 +91,29 @@ TEST(Host, LaunchProcessSetsArgv0) {
   ASSERT_THAT(exit_status.get_future().get(), 0);
 }
 
+TEST(Host, FindProcesses) {
+  SubsystemRAII<FileSystem, HostInfo> subsystems;
+
+  if (test_arg != 0)
+    exit(0);
+
+  ProcessLaunchInfo info;
+  ProcessInstanceInfoList processes;
+  ProcessInstanceInfoMatch match(TestMainArgv0, NameMatch::Equals);
+  info.SetExecutableFile(FileSpec(TestMainArgv0),
+                         /*add_exe_file_as_first_arg=*/true);
+  info.GetArguments().AppendArgument("--gtest_filter=Host.FindProcesses");
+  info.GetArguments().AppendArgument("--test-arg=48");
+  std::promise<int> exit_status;
+  info.SetMonitorProcessCallback([&](lldb::pid_t pid, int signal, int status) {
+    exit_status.set_value(status);
+  });
+  ASSERT_THAT_ERROR(Host::LaunchProcess(info).takeError(), Succeeded());
+  ASSERT_TRUE(Host::FindProcesses(match, processes));
+  ASSERT_EQ(processes[0].GetArg0(), TestMainArgv0);
+  ASSERT_THAT(exit_status.get_future().get(), 0);
+}
+
 #ifdef LLVM_ON_UNIX
 TEST(Host, LaunchProcessDuplicatesHandle) {
   static constexpr llvm::StringLiteral test_msg("Hello subprocess!");