Handling the arg select version for other ops

Author: adam-yang

llvm/lib/Target/DirectX/DXIL.td

@@ -326,7 +326,7 @@ class ArgI8<DXILConstant value_> : Arg {
   let is_i8 = 1;
 }
 
-class IntrinsicSelect<Intrinsic intrinsic_, list<Arg> args_=?> {
+class IntrinsicSelect<Intrinsic intrinsic_, list<Arg> args_> {
   Intrinsic intrinsic = intrinsic_;
   list<Arg> args = args_;
 }

llvm/utils/TableGen/DXILEmitter.cpp

@@ -208,13 +208,23 @@ DXILOperationDesc::DXILOperationDesc(const Record *R) {
           bool IsI8 = Arg->getValueAsBit("is_i8");
           bool IsI32 = Arg->getValueAsBit("is_i32");
           int Index = Arg->getValueAsInt("index");
-          const Record *ValueRec = Arg->getValueAsDef("value");
+          const Record *ValueRec = Arg->getValueAsOptionalDef("value");
 
           DXILArgSelect ArgSelect;
           if (IsI8) {
+            if (!ValueRec) {
+              PrintFatalError(R, Twine("'value' must be defined for i8 "
+                                       "ArgSelect for DXIL operation - ") +
+                                     OpName);
+            }
             ArgSelect.Type = DXILArgSelect::Type::I8;
             ArgSelect.Value = ValueRec->getValueAsInt("value");
           } else if (IsI32) {
+            if (!ValueRec) {
+              PrintFatalError(R, Twine("'value' must be defined for i32 "
+                                       "ArgSelect for DXIL operation - ") +
+                                     OpName);
+            }
             ArgSelect.Type = DXILArgSelect::Type::I32;
             ArgSelect.Value = ValueRec->getValueAsInt("value");
           } else {