Skip to content

Commit aed6967

Browse files
rniwarniwa
committed
[WebKit Checkers] Recognize Objective-C and CF pointer conversion functions.
Recognize dynamic_objc_cast, checked_objc_cast, dynamic_cf_cast, and checked_cf_cast.
1 parent fe6bced commit aed6967

File tree

5 files changed

+198
-6
lines changed

5 files changed

+198
-6
lines changed

‎clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,10 @@ bool isPtrConversion(const FunctionDecl *F) {
418418
FunctionName == "dynamicDowncast" || FunctionName == "downcast" ||
419419
FunctionName == "checkedDowncast" ||
420420
FunctionName == "uncheckedDowncast" || FunctionName == "bitwise_cast" ||
421-
FunctionName == "bridge_cast")
421+
FunctionName == "bridge_cast" || FunctionName == "bridge_id_cast" ||
422+
FunctionName == "dynamic_cf_cast" || FunctionName == "checked_cf_cast" ||
423+
FunctionName == "dynamic_objc_cast" ||
424+
FunctionName == "checked_objc_cast")
422425
return true;
423426

424427
return false;

‎clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -286,15 +286,12 @@ class RawPtrRefCallArgsChecker
286286
overloadedOperatorType == OO_PipePipe)
287287
return true;
288288

289-
if (isCtorOfSafePtr(Callee))
289+
if (isCtorOfSafePtr(Callee) || isPtrConversion(Callee))
290290
return true;
291291

292292
auto name = safeGetName(Callee);
293293
if (name == "adoptRef" || name == "getPtr" || name == "WeakPtr" ||
294-
name == "dynamicDowncast" || name == "downcast" ||
295-
name == "checkedDowncast" || name == "uncheckedDowncast" ||
296-
name == "bitwise_cast" || name == "is" || name == "equal" ||
297-
name == "hash" || name == "isType" ||
294+
name == "is" || name == "equal" || name == "hash" || name == "isType" ||
298295
// FIXME: Most/all of these should be implemented via attributes.
299296
name == "equalIgnoringASCIICase" ||
300297
name == "equalIgnoringASCIICaseCommon" ||

‎clang/test/Analysis/Checkers/WebKit/objc-mock-types.h‎

Lines changed: 143 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#define CF_BRIDGED_TYPE(T) __attribute__((objc_bridge(T)))
66
#define CF_BRIDGED_MUTABLE_TYPE(T) __attribute__((objc_bridge_mutable(T)))
77
typedef CF_BRIDGED_TYPE(id) void * CFTypeRef;
8+
typedef unsigned long long CFTypeID;
89
typedef signed char BOOL;
910
typedef unsigned char Boolean;
1011
typedef signed long CFIndex;
@@ -21,6 +22,8 @@ typedef struct CF_BRIDGED_MUTABLE_TYPE(CFRunLoopRef) __CFRunLoop * CFRunLoopRef;
2122

2223
extern const CFAllocatorRef kCFAllocatorDefault;
2324
typedef struct _NSZone NSZone;
25+
CFTypeID CFGetTypeID(CFTypeRef cf);
26+
CFTypeID CFArrayGetTypeID();
2427
CFMutableArrayRef CFArrayCreateMutable(CFAllocatorRef allocator, CFIndex capacity);
2528
extern void CFArrayAppendValue(CFMutableArrayRef theArray, const void *value);
2629
CFArrayRef CFArrayCreate(CFAllocatorRef allocator, const void **values, CFIndex numValues);
@@ -29,6 +32,7 @@ CFIndex CFArrayGetCount(CFArrayRef theArray);
2932
typedef const struct CF_BRIDGED_TYPE(NSDictionary) __CFDictionary * CFDictionaryRef;
3033
typedef struct CF_BRIDGED_MUTABLE_TYPE(NSMutableDictionary) __CFDictionary * CFMutableDictionaryRef;
3134

35+
CFTypeID CFDictionaryGetTypeID();
3236
CFDictionaryRef CFDictionaryCreate(CFAllocatorRef allocator, const void **keys, const void **values, CFIndex numValues);
3337
CFDictionaryRef CFDictionaryCreateCopy(CFAllocatorRef allocator, CFDictionaryRef theDict);
3438
CFDictionaryRef CFDictionaryCreateMutableCopy(CFAllocatorRef allocator, CFIndex capacity, CFDictionaryRef theDict);
@@ -135,6 +139,8 @@ __attribute__((objc_root_class))
135139

136140
namespace WTF {
137141

142+
void WTFCrash(void);
143+
138144
template<typename T> class RetainPtr;
139145
template<typename T> RetainPtr<T> adoptNS(T*);
140146
template<typename T> RetainPtr<T> adoptCF(T);
@@ -273,11 +279,148 @@ inline CFTypeRef bridge_cast(NSObject *object)
273279
return (__bridge CFTypeRef)object;
274280
}
275281

282+
template <typename ExpectedType>
283+
struct ObjCTypeCastTraits {
284+
public:
285+
static bool isType(id object) { return [object isKindOfClass:[ExpectedType class]]; }
286+
287+
template <typename ArgType>
288+
static bool isType(const ArgType *object) { return [object isKindOfClass:[ExpectedType class]]; }
289+
};
290+
291+
template <typename ExpectedType, typename ArgType>
292+
inline bool is_objc(ArgType * source)
293+
{
294+
return source && ObjCTypeCastTraits<ExpectedType>::isType(source);
295+
}
296+
297+
template<typename T> inline T *checked_objc_cast(id object)
298+
{
299+
if (!object)
300+
return nullptr;
301+
302+
if (!is_objc<T>(object))
303+
WTFCrash();
304+
305+
return reinterpret_cast<T*>(object);
306+
}
307+
308+
template<typename T, typename U> inline T *checked_objc_cast(U *object)
309+
{
310+
if (!object)
311+
return nullptr;
312+
313+
if (!is_objc<T>(object))
314+
WTFCrash();
315+
316+
return static_cast<T*>(object);
317+
}
318+
319+
template<typename T, typename U> RetainPtr<T> dynamic_objc_cast(RetainPtr<U>&& object)
320+
{
321+
if (!is_objc<T>(object.get()))
322+
return nullptr;
323+
return adoptNS(static_cast<T*>(object.leakRef()));
324+
}
325+
326+
template<typename T> RetainPtr<T> dynamic_objc_cast(RetainPtr<id>&& object)
327+
{
328+
if (!is_objc<T>(object.get()))
329+
return nullptr;
330+
return adoptNS(reinterpret_cast<T*>(object.leakRef()));
331+
}
332+
333+
template<typename T, typename U> RetainPtr<T> dynamic_objc_cast(const RetainPtr<U>& object)
334+
{
335+
if (!is_objc<T>(object.get()))
336+
return nullptr;
337+
return static_cast<T*>(object.get());
338+
}
339+
340+
template<typename T> RetainPtr<T> dynamic_objc_cast(const RetainPtr<id>& object)
341+
{
342+
if (!is_objc<T>(object.get()))
343+
return nullptr;
344+
return reinterpret_cast<T*>(object.get());
345+
}
346+
347+
template<typename T> T *dynamic_objc_cast(NSObject *object)
348+
{
349+
if (!is_objc<T>(object))
350+
return nullptr;
351+
return static_cast<T*>(object);
352+
}
353+
354+
template<typename T> T *dynamic_objc_cast(id object)
355+
{
356+
if (!is_objc<T>(object))
357+
return nullptr;
358+
return reinterpret_cast<T*>(object);
359+
}
360+
361+
template <typename> struct CFTypeTrait;
362+
363+
template<typename T> T dynamic_cf_cast(CFTypeRef object)
364+
{
365+
if (!object)
366+
return nullptr;
367+
368+
if (CFGetTypeID(object) != CFTypeTrait<T>::typeID())
369+
return nullptr;
370+
371+
return static_cast<T>(const_cast<CF_BRIDGED_TYPE(id) void*>(object));
372+
}
373+
374+
template<typename T> T checked_cf_cast(CFTypeRef object)
375+
{
376+
if (!object)
377+
return nullptr;
378+
379+
if (CFGetTypeID(object) != CFTypeTrait<T>::typeID())
380+
WTFCrash();
381+
382+
return static_cast<T>(const_cast<CF_BRIDGED_TYPE(id) void*>(object));
383+
}
384+
385+
template<typename T, typename U> RetainPtr<T> dynamic_cf_cast(RetainPtr<U>&& object)
386+
{
387+
if (!object)
388+
return nullptr;
389+
390+
if (CFGetTypeID(object.get()) != CFTypeTrait<T>::typeID())
391+
return nullptr;
392+
393+
return adoptCF(static_cast<T>(const_cast<CF_BRIDGED_TYPE(id) void*>(object.leakRef())));
276394
}
277395

396+
} // namespace WTF
397+
398+
#define WTF_DECLARE_CF_TYPE_TRAIT(ClassName) \
399+
template <> \
400+
struct WTF::CFTypeTrait<ClassName##Ref> { \
401+
static inline CFTypeID typeID(void) { return ClassName##GetTypeID(); } \
402+
};
403+
404+
WTF_DECLARE_CF_TYPE_TRAIT(CFArray);
405+
WTF_DECLARE_CF_TYPE_TRAIT(CFDictionary);
406+
407+
#define WTF_DECLARE_CF_MUTABLE_TYPE_TRAIT(ClassName, MutableClassName) \
408+
template <> \
409+
struct WTF::CFTypeTrait<MutableClassName##Ref> { \
410+
static inline CFTypeID typeID(void) { return ClassName##GetTypeID(); } \
411+
};
412+
413+
WTF_DECLARE_CF_MUTABLE_TYPE_TRAIT(CFArray, CFMutableArray);
414+
WTF_DECLARE_CF_MUTABLE_TYPE_TRAIT(CFDictionary, CFMutableDictionary);
415+
278416
using WTF::RetainPtr;
279417
using WTF::adoptNS;
280418
using WTF::adoptCF;
281419
using WTF::retainPtr;
282420
using WTF::downcast;
283421
using WTF::bridge_cast;
422+
using WTF::is_objc;
423+
using WTF::checked_objc_cast;
424+
using WTF::dynamic_objc_cast;
425+
using WTF::checked_cf_cast;
426+
using WTF::dynamic_cf_cast;

‎clang/test/Analysis/Checkers/WebKit/unretained-call-args.mm‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,28 @@ bool baz(NSObject *obj) {
375375
}
376376
}
377377

378+
namespace ptr_conversion {
379+
380+
SomeObj *provide_obj();
381+
382+
void dobjc(SomeObj* obj) {
383+
[dynamic_objc_cast<OtherObj>(obj) doMoreWork:nil];
384+
}
385+
386+
void cobjc(SomeObj* obj) {
387+
[checked_objc_cast<OtherObj>(obj) doMoreWork:nil];
388+
}
389+
390+
unsigned dcf(CFTypeRef obj) {
391+
return CFArrayGetCount(dynamic_cf_cast<CFArrayRef>(obj));
392+
}
393+
394+
unsigned ccf(CFTypeRef obj) {
395+
return CFArrayGetCount(checked_cf_cast<CFArrayRef>(obj));
396+
}
397+
398+
} // ptr_conversion
399+
378400
@interface TestObject : NSObject
379401
- (void)doWork:(NSString *)msg, ...;
380402
- (void)doWorkOnSelf;

‎clang/test/Analysis/Checkers/WebKit/unretained-local-vars.mm‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,33 @@ void bar() {
359359
}
360360
}
361361

362+
namespace ptr_conversion {
363+
364+
SomeObj *provide_obj();
365+
366+
void dobjc(SomeObj* obj) {
367+
if (auto *otherObj = dynamic_objc_cast<OtherObj>(obj))
368+
[otherObj doMoreWork:nil];
369+
}
370+
371+
void cobjc(SomeObj* obj) {
372+
auto *otherObj = checked_objc_cast<OtherObj>(obj);
373+
[otherObj doMoreWork:nil];
374+
}
375+
376+
unsigned dcf(CFTypeRef obj) {
377+
if (CFArrayRef array = dynamic_cf_cast<CFArrayRef>(obj))
378+
return CFArrayGetCount(array);
379+
return 0;
380+
}
381+
382+
unsigned ccf(CFTypeRef obj) {
383+
CFArrayRef array = checked_cf_cast<CFArrayRef>(obj);
384+
return CFArrayGetCount(array);
385+
}
386+
387+
} // ptr_conversion
388+
362389
bool doMoreWorkOpaque(OtherObj*);
363390

364391
@implementation OtherObj

0 commit comments

Comments
 (0)