Introduction constexpr literal for section name

Author: Renaud-K

mlir/include/mlir/Dialect/GPU/IR/CompilationInterfaces.h

@@ -27,6 +27,7 @@ class ModuleTranslation;
 }
 namespace gpu {
 enum class CompilationTarget : uint32_t;
+constexpr StringLiteral elfSectionName = "section";
 
 /// This class indicates that the attribute associated with this trait is a GPU
 /// offloading translation attribute. These kinds of attributes must implement

mlir/lib/Target/LLVM/NVVM/Target.cpp

@@ -13,6 +13,7 @@
 
 #include "mlir/Target/LLVM/NVVM/Target.h"
 
+#include "mlir/Dialect/GPU/IR/CompilationInterfaces.h"
 #include "mlir/Dialect/GPU/IR/GPUDialect.h"
 #include "mlir/Dialect/LLVMIR/NVVMDialect.h"
 #include "mlir/Target/LLVM/NVVM/Utils.h"
@@ -669,9 +670,9 @@ NVVMTargetAttrImpl::createObject(Attribute attribute, Operation *module,
     properties.push_back(
         builder.getNamedAttr("O", builder.getI32IntegerAttr(target.getO())));
 
-  if (auto section = options.getELFSection(); !section.empty())
-    properties.push_back(
-        builder.getNamedAttr("section", builder.getStringAttr(section)));
+  if (StringRef section = options.getELFSection(); !section.empty())
+    properties.push_back(builder.getNamedAttr(gpu::elfSectionName,
+                                              builder.getStringAttr(section)));
 
   if (!properties.empty())
     objectProps = builder.getDictionaryAttr(properties);

mlir/lib/Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp

@@ -11,6 +11,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "mlir/Dialect/GPU/IR/CompilationInterfaces.h"
 #include "mlir/Dialect/GPU/IR/GPUDialect.h"
 
 #include "mlir/Target/LLVMIR/Dialect/GPU/GPUToLLVMIRTranslation.h"
@@ -124,7 +125,7 @@ LogicalResult SelectObjectAttrImpl::embedBinary(
 
   if (object.getProperties()) {
     if (auto section = mlir::dyn_cast_or_null<mlir::StringAttr>(
-            object.getProperties().get("section"))) {
+            object.getProperties().get(gpu::elfSectionName))) {
       serializedObj->setSection(section.getValue());
     }
   }