[lldb][DWARFASTParserClang][NFC] Remove redundant local variable

Michael137 · Michael137 · commit aeffc01a7247 · 2025-01-21T14:33:37.000Z
Tiny improvement to reviewability of an upcoming refactor.
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -3127,7 +3127,6 @@ size_t DWARFASTParserClang::ParseChildParameters(
         }
       }
 
-      bool skip = false;
       if (is_artificial) {
         // In order to determine if a C++ member function is "const" we
         // have to look at the const-ness of "this"...
@@ -3150,10 +3149,7 @@ size_t DWARFASTParserClang::ParseChildParameters(
             }
           }
         }
-        skip = true;
-      }
-
-      if (!skip) {
+      } else {
         Type *type = die.ResolveTypeUID(param_type_die_form.Reference());
         if (type) {
           function_param_types.push_back(type->GetForwardCompilerType());

Original file line number	Diff line number	Diff line change
`@@ -3127,7 +3127,6 @@ size_t DWARFASTParserClang::ParseChildParameters(`
`3127`	`3127`	`}`
`3128`	`3128`	`}`
`3129`	`3129`
`3130`		`- bool skip = false;`
`3131`	`3130`	`if (is_artificial) {`
`3132`	`3131`	`// In order to determine if a C++ member function is "const" we`
`3133`	`3132`	`// have to look at the const-ness of "this"...`
`@@ -3150,10 +3149,7 @@ size_t DWARFASTParserClang::ParseChildParameters(`
`3150`	`3149`	`}`
`3151`	`3150`	`}`
`3152`	`3151`	`}`
`3153`		`- skip = true;`
`3154`		`- }`
`3155`		`-`
`3156`		`- if (!skip) {`
	`3152`	`+ } else {`
`3157`	`3153`	`Type *type = die.ResolveTypeUID(param_type_die_form.Reference());`
`3158`	`3154`	`if (type) {`
`3159`	`3155`	`function_param_types.push_back(type->GetForwardCompilerType());`