Skip to content

Commit af742b5

Browse files
committed
update punctuation in error message
1 parent 4c722d4 commit af742b5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -872,7 +872,7 @@ LogicalResult ShflOp::verify() {
872872
auto verifyTypeError = [&](Twine desc, Type expectedType,
873873
Type actualType) -> LogicalResult {
874874
return emitOpError("expected " + desc + " to be of type ")
875-
<< expectedType << " but got " << actualType << " instead.";
875+
<< expectedType << " but got " << actualType << " instead";
876876
};
877877

878878
if (returnStructType) {

mlir/test/Target/LLVMIR/nvvm/shfl-sync-invalid.mlir

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ func.func @nvvm_invalid_shfl_pred(%arg0 : i32, %arg1 : f32, %arg2 : i32, %arg3 :
1010
// -----
1111

1212
func.func @nvvm_invalid_shfl_invalid_return_type_1(%arg0 : i32, %arg1 : f32, %arg2 : i32, %arg3 : i32) {
13-
// expected-error@+1 {{expected return type to be of type 'f32' but got 'i32' instead.}}
13+
// expected-error@+1 {{expected return type to be of type 'f32' but got 'i32' instead}}
1414
%0 = nvvm.shfl.sync bfly %arg0, %arg1, %arg2, %arg3 : f32 -> i32
1515
}
1616

1717
// -----
1818

1919
func.func @nvvm_invalid_shfl_invalid_return_type_2(%arg0 : i32, %arg1 : f32, %arg2 : i32, %arg3 : i32) {
20-
// expected-error@+1 {{expected first element in the returned struct to be of type 'f32' but got 'i32' instead.}}
20+
// expected-error@+1 {{expected first element in the returned struct to be of type 'f32' but got 'i32' instead}}
2121
%0 = nvvm.shfl.sync bfly %arg0, %arg1, %arg2, %arg3 {return_value_and_is_valid} : f32 -> !llvm.struct<(i32, i1)>
2222
}

0 commit comments

Comments
 (0)