Skip to content

Commit af878be

Browse files
committed
Remove the assignment of what's a default value
Also check for p2align not having any trailing operands
1 parent 4f2c3de commit af878be

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

llvm/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ X86MCAsmInfoDarwin::X86MCAsmInfoDarwin(const Triple &T) {
4343

4444
AssemblerDialect = AsmWriterFlavor;
4545

46-
// This will be padded with appropriately sized nops.
47-
TextAlignFillValue = 0;
48-
4946
if (!is64Bit)
5047
Data64bitsDirective = nullptr; // we can't emit a 64-bit unit
5148

@@ -94,9 +91,6 @@ X86ELFMCAsmInfo::X86ELFMCAsmInfo(const Triple &T) {
9491

9592
AssemblerDialect = AsmWriterFlavor;
9693

97-
// This will be padded with appropriately sized nops.
98-
TextAlignFillValue = 0;
99-
10094
// Debug Information
10195
SupportsDebugInformation = true;
10296

@@ -134,9 +128,6 @@ X86MCAsmInfoMicrosoft::X86MCAsmInfoMicrosoft(const Triple &Triple) {
134128

135129
AssemblerDialect = AsmWriterFlavor;
136130

137-
// This will be padded with appropriately sized nops.
138-
TextAlignFillValue = 0;
139-
140131
AllowAtInName = true;
141132
}
142133

@@ -170,8 +161,5 @@ X86MCAsmInfoGNUCOFF::X86MCAsmInfoGNUCOFF(const Triple &Triple) {
170161

171162
AssemblerDialect = AsmWriterFlavor;
172163

173-
// This will be padded with appropriately sized nops.
174-
TextAlignFillValue = 0;
175-
176164
AllowAtInName = true;
177165
}

llvm/test/CodeGen/X86/same-align-bytes-with-llasm-llobj.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
; ASM: # %bb.0:
88
; ASM-NEXT: pushq %rax
99
; ASM-NEXT: .cfi_def_cfa_offset 16
10-
; ASM-NEXT: .p2align 4
10+
; ASM-NEXT: .p2align 4{{$}}
1111

1212
;; When we assemble the file, either using the built-in asssembler or going
1313
;; via a textual assembly file, we should get the same padding between the

0 commit comments

Comments
 (0)