review: pass DenseMap by reference

Author: inbelic

clang/include/clang/Parse/ParseHLSLRootSignature.h

@@ -128,7 +128,7 @@ class RootSignatureParser {
 
   // Parse as many optional parameters as possible in any order
   bool ParseOptionalParams(
-      llvm::SmallDenseMap<TokenKind, llvm::hlsl::rootsig::ParamType> RefMap);
+      llvm::SmallDenseMap<TokenKind, llvm::hlsl::rootsig::ParamType> &RefMap);
 
   // Common parsing helpers
   bool ParseRegister(llvm::hlsl::rootsig::Register *Reg);
@@ -138,10 +138,10 @@ class RootSignatureParser {
 
   // Various flags/enum parsing helpers
   template <bool AllowZero = false, typename EnumType>
-  bool ParseEnum(llvm::SmallDenseMap<TokenKind, EnumType> EnumMap,
+  bool ParseEnum(llvm::SmallDenseMap<TokenKind, EnumType> &EnumMap,
                  EnumType *Enum);
   template <typename FlagType>
-  bool ParseFlags(llvm::SmallDenseMap<TokenKind, FlagType> EnumMap,
+  bool ParseFlags(llvm::SmallDenseMap<TokenKind, FlagType> &EnumMap,
                   FlagType *Enum);
   bool
   ParseDescriptorRangeFlags(llvm::hlsl::rootsig::DescriptorRangeFlags *Enum);

clang/lib/Parse/ParseHLSLRootSignature.cpp

@@ -379,7 +379,7 @@ bool RootSignatureParser::ParseParam(ParamType Ref) {
 }
 
 bool RootSignatureParser::ParseOptionalParams(
-    llvm::SmallDenseMap<TokenKind, ParamType> RefMap) {
+    llvm::SmallDenseMap<TokenKind, ParamType> &RefMap) {
   SmallVector<TokenKind> ParamKeywords;
   for (auto RefPair : RefMap)
     ParamKeywords.push_back(RefPair.first);
@@ -454,7 +454,7 @@ bool RootSignatureParser::ParseRegister(Register *Register) {
 
 template <bool AllowZero, typename EnumType>
 bool RootSignatureParser::ParseEnum(
-    llvm::SmallDenseMap<TokenKind, EnumType> EnumMap, EnumType *Enum) {
+    llvm::SmallDenseMap<TokenKind, EnumType> &EnumMap, EnumType *Enum) {
   SmallVector<TokenKind> EnumToks;
   if (AllowZero)
     EnumToks.push_back(TokenKind::int_literal); //  '0' is a valid flag value
@@ -489,7 +489,7 @@ bool RootSignatureParser::ParseEnum(
 
 template <typename FlagType>
 bool RootSignatureParser::ParseFlags(
-    llvm::SmallDenseMap<TokenKind, FlagType> FlagMap, FlagType *Flags) {
+    llvm::SmallDenseMap<TokenKind, FlagType> &FlagMap, FlagType *Flags) {
   // Override the default value to 0 so that we can correctly 'or' the values
   *Flags = FlagType(0);