Skip to content

Commit b0753ae

Browse files
committed
pr-feedback
1 parent 3fdd039 commit b0753ae

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

clang/test/CodeGenHLSL/semantics/semantic.arbitrary.hlsl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,13 @@ void main(float a : AAA, int b : B, float2 c : CC) {
2424
// CHECK-SPIRV: %[[#CC0:]] = load <2 x float>, ptr addrspace(7) @CC0, align 8
2525
// CHECK-SPIRV: call spir_func void @_Z4mainfiDv2_f(float %[[#AAA0]], i32 %[[#B0]], <2 x float> %[[#CC0]]) [ "convergencectrl"(token %0) ]
2626

27+
2728
// CHECK-SPIRV-DAG: ![[#METADATA_0]] = !{![[#METADATA_1:]]}
28-
// CHECK-SPIRV-DAG: ![[#METADATA_1]] = !{i32 30, i32 0}
2929
// CHECK-SPIRV-DAG: ![[#METADATA_2]] = !{![[#METADATA_3:]]}
30-
// CHECK-SPIRV-DAG: ![[#METADATA_3]] = !{i32 30, i32 1}
3130
// CHECK-SPIRV-DAG: ![[#METADATA_4]] = !{![[#METADATA_5:]]}
31+
32+
// CHECK-SPIRV-DAG: ![[#METADATA_1]] = !{i32 30, i32 0}
33+
// CHECK-SPIRV-DAG: ![[#METADATA_3]] = !{i32 30, i32 1}
3234
// CHECK-SPIRV-DAG: ![[#METADATA_5]] = !{i32 30, i32 2}
35+
// | `- Location index
36+
// `-> Decoration "Location"

clang/test/ParserHLSL/semantic_parsing.hlsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void FrenchPony(int GI : garçon_de_café) { }
3333
void UnicodePony(int GI : ℮) { }
3434

3535
// Since P1949 seems Emojis are not allowed, even if in the range
36-
// mentionned in N3337.
36+
// mentioned in N3337.
3737
// https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p1949r7.html
3838

3939
// expected-error@+2 {{unexpected character <U+1F60A>}}

0 commit comments

Comments
 (0)