address review

Author: Job Hernandez

libc/hdr/fcntl_overlay.h

@@ -15,11 +15,9 @@
 
 // Overlay mode
 
-// glibc <stdio.h> header might provide extern inline definitions for few
+// glibc <fcntl.h> header might provide extern inline definitions for few
 // functions, causing external alias errors.  They are guarded by
-// `__USE_EXTERN_INLINES` macro.  We temporarily disable `__USE_EXTERN_INLINES`
-// macro by defining `__NO_INLINE__` before including <stdio.h>.
-// And the same with `__USE_FORTIFY_LEVEL`, which will be temporarily disabled
+// `__USE_FORTIFY_LEVEL`, which will be temporarily disabled
 // with `_FORTIFY_SOURCE`.
 
 #ifdef __USE_FORTIFY_LEVEL
@@ -36,4 +34,4 @@
 #undef LIBC_OLD_USE_FORTIFY_LEVEL
 #endif
 
-#endif // LLVM_LIBC_HDR_STDIO_OVERLAY_H
+#endif // LLVM_LIBC_HDR_FCNTL_OVERLAY_H

libc/hdr/types/CMakeLists.txt

@@ -47,9 +47,9 @@ add_proxy_header_library(
 )
 
 add_proxy_header_library(
-  fcntl_t
+  mode_t
   HDRS
-    fcntl_t.h
+    mode_t.h
   DEPENDS
     ../fcntl_overlay
   FULL_BUILD_DEPENDS

libc/hdr/types/fcntl_t.h renamed to libc/hdr/types/mode_t.h

@@ -1,13 +1,13 @@
-//===-- Definition of macros from fcntl_t.h -------------------------------===//
+//===-- Definition of macros from mode_t.h --------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef LLVM_LIBC_HDR_FCNTL_T_H
-#define LLVM_LIBC_HDR_FCNTL_T_H
+#ifndef LLVM_LIBC_HDR_MODE_T_H
+#define LLVM_LIBC_HDR_MODE_T_H
 
 #ifdef LIBC_FULL_BUILD
 
@@ -19,4 +19,4 @@
 
 #endif // LLVM_LIBC_FULL_BUILD
 
-#endif // LLVM_LIBC_HDR_FCNTL_T_H
+#endif // LLVM_LIBC_HDR_MODE_T_H

libc/src/fcntl/linux/CMakeLists.txt

@@ -28,7 +28,7 @@ add_entrypoint_object(
   HDRS
     ../open.h
   DEPENDS
-    libc.hdr.types.fcntl_t
+    libc.hdr.types.mode_t
     libc.src.__support.OSUtil.osutil
     libc.src.errno.errno
 )
@@ -40,7 +40,7 @@ add_entrypoint_object(
   HDRS
     ../openat.h
   DEPENDS
-    libc.hdr.types.fcntl_t
+    libc.hdr.types.mode_t
     libc.src.__support.OSUtil.osutil
     libc.src.errno.errno
 )

libc/src/fcntl/linux/open.cpp

@@ -13,7 +13,7 @@
 #include "src/__support/macros/config.h"
 #include "src/errno/libc_errno.h"
 
-#include "hdr/types/fcntl_t.h"
+#include "hdr/types/mode_t.h"
 #include <stdarg.h>
 #include <sys/syscall.h> // For syscall numbers.
 

libc/src/fcntl/linux/openat.cpp

@@ -13,7 +13,7 @@
 #include "src/__support/macros/config.h"
 #include "src/errno/libc_errno.h"
 
-#include "hdr/types/fcntl_t.h"
+#include "hdr/types/mode_t.h"
 #include <stdarg.h>
 #include <sys/syscall.h> // For syscall numbers.
 

libc/src/spawn/linux/CMakeLists.txt

@@ -5,7 +5,7 @@ add_entrypoint_object(
   HDRS
     ../posix_spawn.h
   DEPENDS
-    libc.hdr.types.fcntl_t
+    libc.hdr.types.mode_t
     libc.include.spawn
     libc.include.sys_syscall
     libc.include.signal

libc/src/spawn/linux/posix_spawn.cpp

@@ -14,7 +14,7 @@
 #include "src/__support/macros/config.h"
 #include "src/spawn/file_actions.h"
 
-#include "hdr/types/fcntl_t.h"
+#include "hdr/types/mode_t.h"
 #include <signal.h> // For SIGCHLD
 #include <spawn.h>
 #include <sys/syscall.h> // For syscall numbers.

libc/src/sys/stat/linux/CMakeLists.txt

@@ -5,7 +5,7 @@ add_entrypoint_object(
   HDRS
     ../chmod.h
   DEPENDS
-    libc.hdr.types.fcntl_t
+    libc.hdr.types.mode_t
     libc.include.sys_stat
     libc.include.sys_syscall
     libc.src.__support.OSUtil.osutil
@@ -19,7 +19,7 @@ add_entrypoint_object(
   HDRS
     ../fchmod.h
   DEPENDS
-    libc.hdr.types.fcntl_t
+    libc.hdr.types.mode_t
     libc.include.sys_stat
     libc.include.sys_syscall
     libc.src.__support.OSUtil.osutil
@@ -46,7 +46,7 @@ add_entrypoint_object(
   HDRS
     ../mkdir.h
   DEPENDS
-    libc.hdr.types.fcntl_t
+    libc.hdr.types.mode_t
     libc.include.sys_stat
     libc.include.sys_syscall
     libc.src.__support.OSUtil.osutil

libc/src/sys/stat/linux/chmod.cpp

@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include "hdr/types/fcntl_t.h"
+#include "hdr/types/mode_t.h"
 #include "src/__support/macros/config.h"
 #include "src/errno/libc_errno.h"
 #include <sys/stat.h>