added tests

Author: midhuncodes7

llvm/lib/DebugInfo/Symbolize/Symbolize.cpp

@@ -676,13 +676,12 @@ LLVMSymbolizer::getOrCreateObject(const std::string &Path,
                                   const std::string &ArchName) {
   // First check for archive(member) format - more efficient to check closing
   // paren first.
-  size_t CloseParen = Path.rfind(')');
-  if (CloseParen != std::string::npos && CloseParen == Path.length() - 1) {
-    size_t OpenParen = Path.rfind('(', CloseParen);
+  if (!Path.empty() && Path.back() == ')') {
+    size_t OpenParen = Path.rfind('(', Path.size() - 1);
     if (OpenParen != std::string::npos) {
       StringRef ArchivePath = StringRef(Path).substr(0, OpenParen);
       StringRef MemberName =
-          StringRef(Path).substr(OpenParen + 1, CloseParen - OpenParen - 1);
+          StringRef(Path).substr(OpenParen + 1, Path.size() - OpenParen - 2);
       return getOrCreateObjectFromArchive(ArchivePath, MemberName, ArchName);
     }
   }

llvm/test/DebugInfo/symbolize-big-archive-elf.test

@@ -13,6 +13,8 @@
 // RUN: llvm-symbolizer --obj="%t.a(%{t:stem}.tmp-1.o):ppc64le" 0x0 | FileCheck %s --check-prefix=CHECK-1
 // RUN: llvm-symbolizer --default-arch=ppc64le --obj="%t.a(%{t:stem}.tmp-2.o)" 0x0 | FileCheck %s --check-prefix=CHECK-2
 // RUN: llvm-symbolizer --obj="%t.a(%{t:stem}.tmp-2.o):ppc64le" 0x0 | FileCheck %s --check-prefix=CHECK-2
+// RUN: llvm-symbolizer --default-arch=ppc64le --obj="%t.a(%t-1.o)" 0x0 | FileCheck %s --check-prefix=CHECK-1
+// RUN: llvm-symbolizer --default-arch=ppc64le --obj="%t.a(%t-2.o)" 0x0 | FileCheck %s --check-prefix=CHECK-2
 // CHECK-1: foo1
 // CHECK-2: foo2
 
@@ -21,3 +23,9 @@
 // CHECK-ERROR: error: {{.*}}no matching member{{.*}}
 // RUN: not llvm-symbolizer --obj="%t-1.o(%{t:stem}.tmp-1.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-NOTARCHIVE
 // CHECK-NOTARCHIVE: error: '{{.*}}' is not a valid archive
+// RUN: not llvm-symbolizer --obj="%t.a()" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-EMPTY
+// CHECK-EMPTY: {{.*}}no matching member{{.*}}
+// RUN: not llvm-symbolizer --obj="%t.a(%t.o" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-INCORRECT-FORMAT-1
+// CHECK-INCORRECT-FORMAT-1: {{.*}}No such file or directory{{.*}}
+// RUN: not llvm-symbolizer --obj="%t.a%t.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-INCORRECT-FORMAT-2
+// CHECK-INCORRECT-FORMAT-2: {{.*}}Not a directory{{.*}}

llvm/test/DebugInfo/symbolize-big-archive-xcoff.test

@@ -21,6 +21,8 @@
 // RUN: llvm-symbolizer --default-arch=ppc64 --obj="%t.a(%{t:stem}.tmp.o)" 0x0 | FileCheck %s --check-prefix=CHECK-64
 // RUN: llvm-symbolizer --obj="%t.a(%{t:stem}.tmp.o):ppc" 0x0 | FileCheck %s --check-prefix=CHECK-32
 // RUN: llvm-symbolizer --obj="%t.a(%{t:stem}.tmp.o):ppc64" 0x0 | FileCheck %s --check-prefix=CHECK-64
+// RUN: llvm-symbolizer --default-arch=ppc --obj="%t.a(%t.o)" 0x0 | FileCheck %s --check-prefix=CHECK-32
+// RUN: llvm-symbolizer --default-arch=ppc64 --obj="%t.a(%t.o)" 0x0 | FileCheck %s --check-prefix=CHECK-64
 // CHECK-32: foo
 // CHECK-64: foo
 
@@ -29,3 +31,10 @@
 // CHECK-ERROR: error: {{.*}}no matching member{{.*}}
 // RUN: not llvm-symbolizer --obj="%t.o(%{t:stem}.tmp.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-NOTARCHIVE
 // CHECK-NOTARCHIVE: error: '{{.*}}' is not a valid archive
+// RUN: not llvm-symbolizer --obj="%t.a()" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-EMPTY
+// CHECK-EMPTY: {{.*}}no matching member{{.*}}
+// RUN: not llvm-symbolizer --obj="%t.a(%t.o" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-INCORRECT-FORMAT-1
+// CHECK-INCORRECT-FORMAT-1: {{.*}}No such file or directory{{.*}}
+// RUN: not llvm-symbolizer --obj="%t.a%t.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-INCORRECT-FORMAT-2
+// CHECK-INCORRECT-FORMAT-2: {{.*}}Not a directory{{.*}}
+