Skip to content

Commit b149fc7

Browse files
[mlir][scf] Quick fix to scf.execute_region no_inline (#154931)
Asm printer should exclude `no_inline` attr during printing optional attrs at the bottom.
1 parent 7c1d246 commit b149fc7

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

mlir/lib/Dialect/SCF/IR/SCF.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,7 @@ void ExecuteRegionOp::print(OpAsmPrinter &p) {
157157
p.printRegion(getRegion(),
158158
/*printEntryBlockArgs=*/false,
159159
/*printBlockTerminators=*/true);
160-
161-
p.printOptionalAttrDict((*this)->getAttrs());
160+
p.printOptionalAttrDict((*this)->getAttrs(), /*elidedAttrs=*/{"no_inline"});
162161
}
163162

164163
LogicalResult ExecuteRegionOp::verify() {

mlir/test/Dialect/SCF/canonicalize.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1479,7 +1479,7 @@ func.func @execute_region_no_inline() {
14791479
// CHECK-NEXT: scf.execute_region
14801480
// CHECK-NEXT: %[[VAL:.*]] = "test.val"() : () -> i64
14811481
// CHECK-NEXT: scf.yield %[[VAL]] : i64
1482-
// CHECK-NEXT: }
1482+
// CHECK-NOT: no_inline
14831483

14841484
// -----
14851485

0 commit comments

Comments
 (0)