Additional comments

Author: DhruvSrivastavaX

lldb/source/Plugins/Platform/AIX/CMakeLists.txt

@@ -1,5 +1,3 @@
-add_definitions("-D_ALL_SOURCE")
-
 add_lldb_library(lldbPluginPlatformAIX PLUGIN
   PlatformAIX.cpp
 
@@ -11,3 +9,5 @@ add_lldb_library(lldbPluginPlatformAIX PLUGIN
     lldbTarget
     lldbPluginPlatformPOSIX
   )
+
+target_compile_definitions(lldbPluginPlatformAIX PRIVATE "-D_ALL_SOURCE")

lldb/source/Plugins/Platform/AIX/PlatformAIX.cpp

@@ -37,7 +37,7 @@ constexpr int MapAnonymous = 0x10;
 #include <sys/mman.h>
 static_assert(MapVariable == MAP_VARIABLE);
 static_assert(MapPrivate == MAP_PRIVATE);
-static_assert(MapAnonymous = MAP_ANONYMOUS);
+static_assert(MapAnonymous == MAP_ANONYMOUS);
 #endif
 
 using namespace lldb;
@@ -142,10 +142,13 @@ MmapArgList PlatformAIX::GetMmapArgumentList(const ArchSpec &arch, addr_t addr,
                                              addr_t length, unsigned prot,
                                              unsigned flags, addr_t fd,
                                              addr_t offset) {
-  unsigned flags_platform = 0;
-#if defined(_AIX)
-  flags_platform = MapPrivate | MapVariable | MapAnon;
-#endif
+  unsigned flags_platform = MapVariable;
+
+  if (flags & eMmapFlagsPrivate)
+    flags_platform |= MapPrivate;
+  if (flags & eMmapFlagsAnon)
+    flags_platform |= MapAnonymous;
+
   MmapArgList args({addr, length, prot, flags_platform, fd, offset});
   return args;
 }

lldb/source/Plugins/Platform/AIX/PlatformAIX.h

@@ -12,8 +12,7 @@
 #include "Plugins/Platform/POSIX/PlatformPOSIX.h"
 #include "Plugins/TypeSystem/Clang/TypeSystemClang.h"
 
-namespace lldb_private {
-namespace platform_aix {
+namespace lldb_private::platform_aix {
 
 class PlatformAIX : public PlatformPOSIX {
 public:
@@ -64,7 +63,6 @@ class PlatformAIX : public PlatformPOSIX {
   std::unique_ptr<TypeSystemClang> m_type_system_up;
 };
 
-} // namespace platform_aix
-} // namespace lldb_private
+} // namespace lldb_private::platform_aix
 
 #endif // LLDB_SOURCE_PLUGINS_PLATFORM_AIX_PLATFORMAIX_H