remove shutdown

Author: grypp

mlir/include/mlir/IR/Remarks.h

@@ -429,16 +429,17 @@ class RemarkEngine {
   /// main remark streamer.
   ~RemarkEngine();
 
-  /// Shutdown the remark engine. This will finalize the remark engine and
-  /// close the output file.
-  void shutdown();
-
   /// Setup the remark engine with the given output path and format.
   LogicalResult
   initialize(std::unique_ptr<MLIRRemarkStreamerBase> streamer,
              std::unique_ptr<RemarkEmittingPolicyBase> remarkEmittingPolicy,
              std::string *errMsg);
 
+  /// Get the remark emitting policy.
+  RemarkEmittingPolicyBase *getRemarkEmittingPolicy() const {
+    return remarkEmittingPolicy.get();
+  }
+
   /// Report a remark.
   void report(const Remark &&remark);
 

mlir/lib/IR/Remarks.cpp

@@ -237,12 +237,6 @@ void RemarkEngine::reportImpl(const Remark &remark) {
     emitRemark(remark.getLocation(), remark.getMsg());
 }
 
-void RemarkEngine::shutdown() {
-  if (remarkEmittingPolicy) {
-    remarkEmittingPolicy->finalize();
-  }
-}
-
 void RemarkEngine::report(const Remark &&remark) {
   if (remarkEmittingPolicy)
     remarkEmittingPolicy->reportRemark(remark);

mlir/lib/Tools/mlir-opt/MlirOptMain.cpp

@@ -618,7 +618,8 @@ performActions(raw_ostream &os,
   os << OpWithState(op.get(), asmState) << '\n';
 
   if (remark::detail::RemarkEngine *engine = ctx.getRemarkEngine())
-    engine->shutdown();
+    engine->getRemarkEmittingPolicy()->finalize();
+
   return success();
 }
 

mlir/unittests/IR/RemarkTest.cpp

@@ -374,7 +374,7 @@ TEST(Remark, TestRemarkFinal) {
         << pass4Msg;
 
     // Finalize the remark engine
-    context.getRemarkEngine()->shutdown();
+    policy->finalize();
   }
 
   llvm::errs().flush();