Update CO_BROADCAST and fix alphabetical order

Author: JDPailleux

flang/include/flang/Optimizer/Builder/IntrinsicCall.h

@@ -225,10 +225,6 @@ struct IntrinsicLibrary {
   fir::ExtendedValue genCharacterCompare(mlir::Type,
                                          llvm::ArrayRef<fir::ExtendedValue>);
   mlir::Value genCmplx(mlir::Type, llvm::ArrayRef<mlir::Value>);
-  void genCoBroadcast(llvm::ArrayRef<fir::ExtendedValue>);
-  void genCoMax(llvm::ArrayRef<fir::ExtendedValue>);
-  void genCoMin(llvm::ArrayRef<fir::ExtendedValue>);
-  void genCoSum(llvm::ArrayRef<fir::ExtendedValue>);
   mlir::Value genConjg(mlir::Type, llvm::ArrayRef<mlir::Value>);
   fir::ExtendedValue genCount(mlir::Type, llvm::ArrayRef<fir::ExtendedValue>);
   void genCpuTime(llvm::ArrayRef<fir::ExtendedValue>);
@@ -250,6 +246,10 @@ struct IntrinsicLibrary {
   template <mlir::arith::CmpIPredicate pred>
   fir::ExtendedValue genCPtrCompare(mlir::Type,
                                     llvm::ArrayRef<fir::ExtendedValue>);
+  void genCoBroadcast(llvm::ArrayRef<fir::ExtendedValue>);
+  void genCoMax(llvm::ArrayRef<fir::ExtendedValue>);
+  void genCoMin(llvm::ArrayRef<fir::ExtendedValue>);
+  void genCoSum(llvm::ArrayRef<fir::ExtendedValue>);
   mlir::Value genCosd(mlir::Type, llvm::ArrayRef<mlir::Value>);
   mlir::Value genCospi(mlir::Type, llvm::ArrayRef<mlir::Value>);
   void genDateAndTime(llvm::ArrayRef<fir::ExtendedValue>);

flang/lib/Optimizer/Builder/IntrinsicCall.cpp

@@ -400,7 +400,7 @@ static constexpr IntrinsicHandler handlers[]{
     {"co_broadcast",
      &I::genCoBroadcast,
      {{{"a", asBox},
-       {"source_image", asAddr, handleDynamicOptional},
+       {"source_image", asAddr},
        {"stat", asAddr, handleDynamicOptional},
        {"errmsg", asBox, handleDynamicOptional}}},
      /*isElemental*/ false},
@@ -3681,14 +3681,14 @@ mlir::Value IntrinsicLibrary::genCmplx(mlir::Type resultType,
 void IntrinsicLibrary::genCoBroadcast(llvm::ArrayRef<fir::ExtendedValue> args) {
   checkCoarrayEnabled();
   assert(args.size() == 4);
-  mlir::Value refNone =
-      builder
-          .create<fir::AbsentOp>(loc, builder.getRefType(builder.getI32Type()))
-          .getResult();
-  mlir::Value sourceImage =
-      isStaticallyAbsent(args[1]) ? refNone : fir::getBase(args[1]);
+  mlir::Value sourceImage = fir::getBase(args[1]);
   mlir::Value status =
-      isStaticallyAbsent(args[2]) ? refNone : fir::getBase(args[2]);
+      isStaticallyAbsent(args[2])
+          ? builder
+                .create<fir::AbsentOp>(loc,
+                                       builder.getRefType(builder.getI32Type()))
+                .getResult()
+          : fir::getBase(args[2]);
   mlir::Value errmsg =
       isStaticallyAbsent(args[3])
           ? builder.create<fir::AbsentOp>(loc, PRIF_ERRMSG_TYPE).getResult()