Skip to content

Commit b2fb3e8

Browse files
Apply suggestions from code review
Co-authored-by: EugeneZelenko <[email protected]>
1 parent 3fa56c1 commit b2fb3e8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

clang-tools-extra/clang-tidy/llvm/UseNewMLIROpBuilderCheck.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ EditGenerator rewrite(RangeSelector Call, RangeSelector Builder) {
8888
return llvm::make_error<llvm::StringError>(llvm::errc::invalid_argument,
8989
"unexpected end of file");
9090
}
91-
bool hasArgs = Arg->getKind() != clang::tok::r_paren;
91+
const bool hasArgs = Arg->getKind() != clang::tok::r_paren;
9292

9393
Expected<CharSourceRange> BuilderRange = Builder(Result);
9494
if (!BuilderRange)
@@ -110,7 +110,7 @@ EditGenerator rewrite(RangeSelector Call, RangeSelector Builder) {
110110
? "*this"
111111
: llvm::formatv("*{}", BuilderText).str();
112112
}
113-
StringRef OpType = GetText(CharSourceRange::getTokenRange(
113+
const StringRef OpType = GetText(CharSourceRange::getTokenRange(
114114
LessToken->getEndLoc(), EndToken->getLastLoc()));
115115
Replace.Replacement = llvm::formatv("{}::create({}{}", OpType, BuilderText,
116116
hasArgs ? ", " : "");

0 commit comments

Comments
 (0)