Give descriptive names to the test cases in dst-error.hlsl and remove the test from dst.hlsl

Author: metkarpoonam

clang/test/CodeGenHLSL/builtins/dst.hlsl

@@ -44,42 +44,27 @@ double4 dstWithDouble(double4 p1, double4 p2)
     return dst(p1, p2);
 }
 
-// CHECK-LABEL: define noundef nofpclass(nan inf) <4 x float> @_Z9testfloatff(
+// CHECK-LABEL: define noundef nofpclass(nan inf) <4 x float> @_Z16dstWithScalarInpff(
 // CHECK-SAME: float noundef nofpclass(nan inf) [[P:%.*]], float noundef nofpclass(nan inf) [[Q:%.*]]) local_unnamed_addr #[[ATTR0]] {
 // CHECK: [[MULRES:%.*]] = fmul reassoc nnan ninf nsz arcp afn float [[Q]], [[P]]
 // CHECK-NEXT: [[VECINIT:%.*]] = insertelement <4 x float> <float 1.000000e+00, float poison, float poison, float poison>, float [[MULRES]], i64 1
 // CHECK-NEXT: [[VECINIT3:%.*]] = insertelement <4 x float> [[VECINIT]], float [[P]], i64 2
 // CHECK-NEXT: [[VECINIT5:%.*]] = insertelement <4 x float> [[VECINIT3]], float [[Q]], i64 3
 // CHECK-NEXT:  ret <4 x float> [[VECINIT5]]
-float4 testfloat(float a, float b)
+float4 dstWithScalarInp(float a, float b)
 {
     return dst(a, b);
 }
 
-// CHECK-LABEL: define noundef nofpclass(nan inf) <4 x float> @_Z10testfloat4fDv4_f(
+// CHECK-LABEL: define noundef nofpclass(nan inf) <4 x float> @_Z22dstWithScalarAndVectorfDv4_f(
 // CHECK-SAME: float noundef nofpclass(nan inf) [[P:%.*]], <4 x float> noundef nofpclass(nan inf) [[Q:%.*]]) local_unnamed_addr #[[ATTR0]] {
 // CHECK: [[VECEXT1:%.*]] = extractelement <4 x float> [[Q:%.*]], i64 1
 // CHECK-NEXT: [[MULRES:%.*]] = fmul reassoc nnan ninf nsz arcp afn float [[VECEXT1]], [[P]]
 // CHECK-NEXT: [[VECINIT:%.*]] = insertelement <4 x float> <float 1.000000e+00, float poison, float poison, float poison>, float [[MULRES]], i64 1
 // CHECK-NEXT: [[VECINIT3:%.*]] = insertelement <4 x float> [[VECINIT]], float %a, i64 2
 // CHECK-NEXT: [[VECINIT5:%.*]] = shufflevector <4 x float> [[VECINIT3]], <4 x float> [[Q]], <4 x i32> <i32 0, i32 1, i32 2, i32 7>
 // CHECK-NEXT:  ret <4 x float> [[VECINIT5]]
-float4 testfloat4(float a, float4 b)
+float4 dstWithScalarAndVector(float a, float4 b)
 {
     return dst(a, b);
-}
-
-// CHECK-LABEL: define noundef nofpclass(nan inf) <4 x half> @_Z21testRetTypeShriinkingDv4_fS_(
-// CHECK-SAME: <4 x float> noundef nofpclass(nan inf) [[P:%.*]], <4 x float> noundef nofpclass(nan inf) [[Q:%.*]]) local_unnamed_addr #[[ATTR0]] {
-// CHECK: [[VECEXT:%.*]] = extractelement <4 x float> [[P]], i64 1
-// CHECK-NEXT: [[VECEXT1:%.*]] = extractelement <4 x float> [[Q]], i64 1
-// CHECK-NEXT: [[MULRES:%.*]] = fmul reassoc nnan ninf nsz arcp afn float [[VECEXT1]], [[VECEXT]]
-// CHECK-NEXT: [[VECINIT:%.*]] = insertelement <4 x float> <float 1.000000e+00, float poison, float poison, float poison>, float [[MULRES]], i64 1
-// CHECK-NEXT: [[VECINIT3:%.*]] = shufflevector <4 x float> [[VECINIT]], <4 x float> %a, <4 x i32> <i32 0, i32 1, i32 6, i32 poison>
-// CHECK-NEXT: [[VECINIT5:%.*]] = shufflevector <4 x float> %vecinit3.i, <4 x float> %b, <4 x i32> <i32 0, i32 1, i32 2, i32 7>
-// CHECK-NEXT: [[CONV:%.*]] = fptrunc reassoc nnan ninf nsz arcp afn <4 x float> [[VECINIT5]] to <4 x half>
-// CHECK-NEXT:  ret <4 x half> [[CONV]]
-half4 testRetTypeShriinking(float4 a, float4 b)
-{
-    return dst(a, b);
-}
+}

clang/test/SemaHLSL/BuiltIns/dst-error.hlsl

@@ -36,15 +36,15 @@ float4 test_3_components(float3 p0, float3 p1)
   // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate function not viable: no known conversion from 'vector<float, 3>' to 'vector<double, 4>' for 1st argument}}
 }
 
-float4 test_float2(double4 p0, float4 p1)
+float4 test_with_ambiguous_inp(double4 p0, float4 p1)
 {
     return dst(p0, p1);
   // expected-error@-1 {{call to 'dst' is ambiguous}}
   // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate function}}
   // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate function}}
 }
 
-float2 test_float2(float4 p0, float4 p1)
+float2 test_with_return_float2(float4 p0, float4 p1)
 {
     return dst(p0, p1);
   // expected-warning@-1 {{implicit conversion truncates vector: 'vector<float, 4>' (vector of 4 'float' values) to 'vector<float, 2>' (vector of 2 'float' values)}}