Skip to content

Commit b340870

Browse files
author
Tom Yang
committed
tweak Target.h documentation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
1 parent 8f486e8 commit b340870

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

lldb/include/lldb/Target/Target.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,9 @@ class Target : public std::enable_shared_from_this<Target>,
640640
///
641641
/// \param[in] notify
642642
/// If notify is true, and the Module is new to this Target,
643-
/// Target::ModulesDidLoad will be called.
643+
/// Target::ModulesDidLoad will be called. See note in
644+
/// Target::ModulesDidLoad about thread-safety with
645+
/// Target::GetOrCreateModule.
644646
/// If notify is false, it is assumed that the caller is adding
645647
/// multiple Modules and will call ModulesDidLoad with the
646648
/// full list at the end.
@@ -941,8 +943,8 @@ class Target : public std::enable_shared_from_this<Target>,
941943
/// - TargetProperties::GetPreloadSymbols()
942944
/// - TargetProperties::GetParallelModuleLoad()
943945
///
944-
/// Warning: if called in parallel with Target::GetOrCreateModule, this may
945-
/// result in a ABBA deadlock situation.
946+
/// Warning: if preloading is active and this is called in parallel with
947+
/// Target::GetOrCreateModule, this may result in a ABBA deadlock situation.
946948
void ModulesDidLoad(ModuleList &module_list);
947949

948950
void ModulesDidUnload(ModuleList &module_list, bool delete_locations);

0 commit comments

Comments
 (0)