personality can't be empty

DataCorrupted · DataCorrupted · commit b4f7ddfad7ad · 2024-08-22T10:44:57.000-07:00
Signed-off-by: Peter Rong &lt;PeterRong@meta.com&gt;
diff --git a/lld/MachO/BPSectionOrderer.cpp b/lld/MachO/BPSectionOrderer.cpp
@@ -78,10 +78,7 @@ static uint64_t getUnwindInfoEncodingHash(const InputSection *isec) {
       cu.relocateOneCompactUnwindEntry(d);
       if (cu.lsda)
         return xxHash64("HAS LSDA");
-      StringRef name = (cu.personality == nullptr) ? "<none>"
-                       : cu.personality->getName().empty()
-                           ? "<unnamed>"
-                           : cu.personality->getName();
+      StringRef name = (cu.personality) ? cu.personality->getName() : "<null>";
       return xxHash64((name + ";" + Twine::utohexstr(cu.encoding)).str());
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -78,10 +78,7 @@ static uint64_t getUnwindInfoEncodingHash(const InputSection *isec) {`
`78`	`78`	`cu.relocateOneCompactUnwindEntry(d);`
`79`	`79`	`if (cu.lsda)`
`80`	`80`	`return xxHash64("HAS LSDA");`
`81`		`- StringRef name = (cu.personality == nullptr) ? "<none>"`
`82`		`- : cu.personality->getName().empty()`
`83`		`- ? "<unnamed>"`
`84`		`- : cu.personality->getName();`
	`81`	`+ StringRef name = (cu.personality) ? cu.personality->getName() : "<null>";`
`85`	`82`	`return xxHash64((name + ";" + Twine::utohexstr(cu.encoding)).str());`
`86`	`83`	`}`
`87`	`84`	`}`