Skip to content

Commit b50f200

Browse files
committed
Address review comments.
1 parent 3f4136a commit b50f200

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

mlir/include/mlir/Dialect/XeGPU/uArch/uArchBase.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ namespace xegpu {
3030
namespace uArch {
3131

3232
// An enum class to represent the scope of an instruction
33-
enum class InstructionScope { WorkItem, Subgroup, Workgroup, Cluster };
33+
enum class InstructionScope { Lane, Subgroup, Workgroup, Cluster };
3434
enum class InstructionKind {
3535
DPAS, // Dot Product Accumulate Systolic (DPAS) is a matrix
3636
// multiply-add operation
@@ -66,8 +66,9 @@ struct Instruction {
6666
InstructionScope getScope() { return scope; }
6767

6868
protected:
69-
InstructionKind instKind;
70-
InstructionScope scope;
69+
InstructionKind instKind; // Specific InstructionKind (e.g., DPAS)
70+
InstructionScope scope; // scope of the instruction (e.g., lane, subgroup,
71+
// workgroup, cluster)
7172
// @TODO: Add more fields as needed
7273
};
7374

0 commit comments

Comments
 (0)