fix review

Author: HerrCai0907

clang-tools-extra/clang-tidy/custom/QueryCheck.cpp

@@ -91,12 +91,12 @@ void QueryCheck::check(const MatchFinder::MatchResult &Result) {
       diag(Node.getSourceRange().getBegin(), Message, Level);
     }
   };
-  for (auto &[Name, Node] : Result.Nodes.getMap())
+  for (const auto &[Name, Node] : Result.Nodes.getMap())
     Emit(Diags, Name, Node, DiagnosticIDs::Error);
-  for (auto &[Name, Node] : Result.Nodes.getMap())
+  for (const auto &[Name, Node] : Result.Nodes.getMap())
     Emit(Diags, Name, Node, DiagnosticIDs::Warning);
   // place Note last, otherwise it will not be emitted
-  for (auto &[Name, Node] : Result.Nodes.getMap())
+  for (const auto &[Name, Node] : Result.Nodes.getMap())
     Emit(Diags, Name, Node, DiagnosticIDs::Note);
 }
 } // namespace clang::tidy::custom

clang-tools-extra/clang-tidy/custom/QueryCheck.h

@@ -18,10 +18,8 @@
 
 namespace clang::tidy::custom {
 
-/// FIXME: Write a short description.
-///
-/// For the user-facing documentation see:
-/// http://clang.llvm.org/extra/clang-tidy/checks/custom/query.html
+/// Implement of Clang-Query based check.
+/// Not directly visible to users.
 class QueryCheck : public ClangTidyCheck {
 public:
   QueryCheck(llvm::StringRef Name, const ClangTidyOptions::CustomCheckValue &V,

clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp

@@ -61,7 +61,7 @@ Configuration files:
                                  globs can be specified as a list instead of a
                                  string.
   CustomChecks                 - Array of user defined checks based on
-                                 clang-query syntax.
+                                 Clang-Query syntax.
   ExcludeHeaderFilterRegex     - Same as '--exclude-header-filter'.
   ExtraArgs                    - Same as '--extra-arg'.
   ExtraArgsBefore              - Same as '--extra-arg-before'.

clang-tools-extra/docs/clang-tidy/QueryBasedCustomChecks.rst

@@ -8,9 +8,9 @@ Introduction
 This page provides examples of how to add query based custom checks for
 :program:`clang-tidy`.
 
-Custom checks are based on clang-query syntax. Every custom checks will be
-registered in `custom` module to avoid name conflict. They can be enabled or
-disabled by the checks option like the builtin checks.
+Custom checks are based on :program:`clang-query` syntax. Every custom checks
+will be registered in `custom` module to avoid name conflict. They can be
+enabled or disabled by the checks option like the built-in checks.
 
 Custom checks support inheritance from parent configurations like other
 configuration items.

clang-tools-extra/docs/clang-tidy/index.rst

@@ -294,7 +294,7 @@ An overview of all the command-line options:
                                    globs can be specified as a list instead of a
                                    string.
     CustomChecks                 - Array of user defined checks based on
-                                   clang-query syntax.
+                                   Clang-Query syntax.
     ExcludeHeaderFilterRegex     - Same as '--exclude-header-filter'.
     ExtraArgs                    - Same as '--extra-arg'.
     ExtraArgsBefore              - Same as '--extra-arg-before'.

clang-tools-extra/test/clang-tidy/infrastructure/Inputs/custom-query-check/empty-clang-tidy.yml

@@ -1 +1 @@
-InheritParentConfig: false
+InheritParentConfig: false