Skip to content

Commit b611801

Browse files
committed
implement feedback
1 parent de6ae29 commit b611801

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

llvm/lib/Transforms/Scalar/JumpThreading.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1498,15 +1498,13 @@ Constant *JumpThreadingPass::evaluateOnPredecessorEdge(BasicBlock *BB,
14981498
BasicBlock *PredPredBB,
14991499
Value *V,
15001500
const DataLayout &DL) {
1501-
SmallPtrSet<Value *, 8> Visited;
1501+
SmallPtrSet<Value *, 8> Visited({V});
15021502
return evaluateOnPredecessorEdge(BB, PredPredBB, V, DL, Visited);
15031503
}
15041504

15051505
Constant *JumpThreadingPass::evaluateOnPredecessorEdge(
15061506
BasicBlock *BB, BasicBlock *PredPredBB, Value *V, const DataLayout &DL,
15071507
SmallPtrSet<Value *, 8> &Visited) {
1508-
Visited.insert(V);
1509-
15101508
BasicBlock *PredBB = BB->getSinglePredecessor();
15111509
assert(PredBB && "Expected a single predecessor");
15121510

@@ -1537,10 +1535,12 @@ Constant *JumpThreadingPass::evaluateOnPredecessorEdge(
15371535
Constant *Op0 = nullptr;
15381536
Constant *Op1 = nullptr;
15391537
if (Value *V0 = CondCmp->getOperand(0); !Visited.contains(V0)) {
1538+
Visited.insert(V0);
15401539
Op0 = evaluateOnPredecessorEdge(BB, PredPredBB, V0, DL, Visited);
15411540
Visited.erase(V0);
15421541
}
15431542
if (Value *V1 = CondCmp->getOperand(1); !Visited.contains(V1)) {
1543+
Visited.insert(V1);
15441544
Op1 = evaluateOnPredecessorEdge(BB, PredPredBB, V1, DL, Visited);
15451545
Visited.erase(V1);
15461546
}

0 commit comments

Comments
 (0)