Address review comments

Author: metkarpoonam

clang/lib/Headers/hlsl/hlsl_intrinsics.h

@@ -294,11 +294,14 @@ bool4 and(bool4 x, bool4 y);
 // or builtins
 //===----------------------------------------------------------------------===//
 
-/// \fn T or(T x, T y)
-/// \brief Returns the bitwise OR of the two input values, \a x and \a y.
-/// \param x The first input value and y The second input value.
-///
-/// \returns A boolean vector by performing a logical OR operation elementwise.
+/// \fn bool or(bool x, bbol y)
+/// \brief Logically ors two boolean vectors elementwise and produces a bool
+/// vector output.
+
+// TODO: Clean up clang-format marker once we've resolved
+//       https://github.com/llvm/llvm-project/issues/128979
+//
+// clang-format off
 _HLSL_BUILTIN_ALIAS(__builtin_hlsl_or)
 bool or(bool, bool);
 _HLSL_BUILTIN_ALIAS(__builtin_hlsl_or)
@@ -307,6 +310,7 @@ _HLSL_BUILTIN_ALIAS(__builtin_hlsl_or)
 bool3 or(bool3, bool3);
 _HLSL_BUILTIN_ALIAS(__builtin_hlsl_or)
 bool4 or(bool4, bool4);
+// clang-format on
 
 //===----------------------------------------------------------------------===//
 // any builtins

clang/lib/Sema/SemaHLSL.cpp

@@ -2311,11 +2311,10 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
     if (CheckVectorElementCallArgs(&SemaRef, TheCall))
       return true;
 
-    // Ensure input expr type is a scalar/vector and the same as the return type
+    // Ensure input expr type is a scalar/vector of type Boolty
     if (CheckScalarOrVector(&SemaRef, TheCall, getASTContext().BoolTy, 0))
       return true;
 
-    // Ensure input parameter type is bool
     ExprResult A = TheCall->getArg(0);
     QualType ArgTyA = A.get()->getType();
 

clang/test/CodeGenHLSL/builtins/or.hlsl

@@ -8,10 +8,9 @@
 //CHECK-NEXT:    [[HLSL_OR:%.*]] = or i1 [[x]], [[y]]
 //CHECK-NEXT:    ret i1 [[HLSL_OR]]
 //CHECK_NEXT:  }
-bool test_or_bool(bool x, bool y)
+bool test_and_scalar(bool x, bool y)
 {
     return or(x, y);
-
 }
 
 //CHECK-LABEL: define noundef <2 x i1> @_Z13test_or_bool2Dv2_bS_(