address reviewer comments

Signed-off-by: Bangtian Liu <[email protected]>

Author: bangtianliu

mlir/include/mlir-c/Dialect/Linalg.h

@@ -36,7 +36,7 @@ MLIR_CAPI_EXPORTED MlirLinalgContractionDimensions
 mlirLinalgInferContractionDimensions(MlirOperation op);
 
 MLIR_CAPI_EXPORTED MlirLinalgContractionDimensions
-mlirLinalgInferContractionDimensionsFromMaps(MlirAffineMap const *indexingMaps,
+mlirLinalgInferContractionDimensionsFromMaps(const MlirAffineMap *indexingMaps,
                                              intptr_t numMaps);
 
 MLIR_CAPI_EXPORTED bool mlirLinalgIsAConvolutionOp(MlirOperation op);

mlir/lib/CAPI/Dialect/Linalg.cpp

@@ -77,7 +77,7 @@ mlirLinalgInferContractionDimensions(MlirOperation op) {
 }
 
 MLIR_CAPI_EXPORTED MlirLinalgContractionDimensions
-mlirLinalgInferContractionDimensionsFromMaps(MlirAffineMap const *indexingMaps,
+mlirLinalgInferContractionDimensionsFromMaps(const MlirAffineMap *indexingMaps,
                                              intptr_t numMaps) {
   MlirLinalgContractionDimensions result{};
   if (!indexingMaps || numMaps <= 0)
@@ -94,18 +94,17 @@ mlirLinalgInferContractionDimensionsFromMaps(MlirAffineMap const *indexingMaps,
   if (failed(maybeDims))
     return result;
 
-  const linalg::ContractionDimensions &contractionDims = *maybeDims;
   MLIRContext *ctx = maps[0].getContext();
 
   auto toAttr = [&ctx](const SmallVector<unsigned, 2> &vals) -> MlirAttribute {
     return wrap(
         DenseI32ArrayAttr::get(ctx, llvm::to_vector_of<int32_t, 2>(vals)));
   };
 
-  result.batch = toAttr(contractionDims.batch);
-  result.m = toAttr(contractionDims.m);
-  result.n = toAttr(contractionDims.n);
-  result.k = toAttr(contractionDims.k);
+  result.batch = toAttr(maybeDims->batch);
+  result.m = toAttr(maybeDims->m);
+  result.n = toAttr(maybeDims->n);
+  result.k = toAttr(maybeDims->k);
 
   return result;
 }