Skip to content

Commit b77d261

Browse files
committed
update comment
1 parent f74d424 commit b77d261

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

llvm/lib/ExecutionEngine/Orc/ObjectFileInterface.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -261,12 +261,12 @@ getXCOFFObjectFileSymbolInfo(ExecutionSession &ES,
261261
if (!SymFlags)
262262
return SymFlags.takeError();
263263

264-
// By default, only shared library with F_SHROBJ in the xcoff header will
265-
// have SF_Exported. On AIX, we require the linker with the help of an
266-
// export list to determine the visibility of the symbol. This mimics the
267-
// behaviour of -bautoexp and CreateExportList utilities. In the abscence of
268-
// the export list, this is the best we can do.
269-
// TODO: Revisit
264+
// TODO: Revisit symbol visibility
265+
// On AIX, symbols with C_EXT and C_WEAKEXT symbols have no specified
266+
// visibility are considered to have Default scope for LinkGraph. When the
267+
// object is not a DSO, symbol visibility is not specified. In the absence
268+
// of an Export List, its reasonable to minimic roughly the behaviour of
269+
// -bexpall or CreateExportList.
270270
*SymFlags |= JITSymbolFlags::Exported;
271271

272272
I.SymbolFlags[ES.intern(std::move(*Name))] = std::move(*SymFlags);

0 commit comments

Comments
 (0)