Skip to content

Commit b7cfe8b

Browse files
committed
Try to improve FIXME
1 parent 806fa90 commit b7cfe8b

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

llvm/lib/CodeGen/ScheduleDAGInstrs.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -275,9 +275,12 @@ void ScheduleDAGInstrs::addPhysRegDataDeps(SUnit *SU, unsigned OperIdx) {
275275
bool ImplicitPseudoUse = false;
276276
SDep Dep;
277277
if (UseOpIdx < 0) {
278-
// FIXME: UseOpIdx can be passed to computeOperandLatency, which can
279-
// pass it to findUseIdx, which treats it as unsigned. If this is
280-
// the expected behavior, it should be commented.
278+
// FIXME: UseOpIdx passed to computeOperandLatency below should be
279+
// non-negative. Currently a negative value is passed if UseOpIdx < 0
280+
// and ImplicitPseudoDef is false. This could be fixed by setting
281+
// ImplicitPseudoUse to true here (which is probably the right thing
282+
// to do), but this crashes Hexagon backend and causes many test
283+
// changes that need investigation.
281284
Dep = SDep(SU, SDep::Artificial);
282285
} else {
283286
// Set the hasPhysRegDefs only for physreg defs that have a use within

0 commit comments

Comments
 (0)