Skip to content

Commit b7edcfc

Browse files
committed
apply suggested changes
1 parent 73dd1f5 commit b7edcfc

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

libc/test/src/__support/str_to_float_comparison_test.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ static inline uint64_t fastHexToU64(const char *inStr) {
7272
static void parseLine(const char *line, ParseResult &parseResult,
7373
int32_t &curFails, int32_t &curBitDiffs) {
7474

75-
if (line[0] == '#') {
75+
if (line[0] == '#')
7676
return;
77-
}
77+
7878
parseResult.total += 1;
7979
uint32_t expectedFloatRaw;
8080
uint64_t expectedDoubleRaw;
@@ -187,13 +187,13 @@ ParseStatus checkFile(char *inputFileName, ParseResult &parseResult) {
187187
return ParseStatus::SUCCESS;
188188
}
189189

190-
ParseStatus updateResult(ParseStatus result, ParseStatus curResult) {
191-
if (curResult == ParseStatus::FILE_ERROR) {
192-
result = ParseStatus::FILE_ERROR;
193-
} else if (curResult == ParseStatus::PARSE_ERROR) {
194-
result = ParseStatus::PARSE_ERROR;
190+
ParseStatus updateStatus(ParseStatus parse_status, ParseStatus cur_status) {
191+
if (cur_status == ParseStatus::FILE_ERROR) {
192+
parse_status = ParseStatus::FILE_ERROR;
193+
} else if (cur_status == ParseStatus::PARSE_ERROR) {
194+
parse_status = ParseStatus::PARSE_ERROR;
195195
}
196-
return result;
196+
return parse_status;
197197
}
198198

199199
TEST(LlvmLibcStrToFloatComparisonTest, CheckFloats) {
@@ -214,14 +214,14 @@ TEST(LlvmLibcStrToFloatComparisonTest, CheckFloats) {
214214
char *files = LIBC_NAMESPACE::getenv("FILES");
215215

216216
if (files == nullptr) {
217-
ParseStatus curResult = checkBuffer(parseResult);
218-
parseStatus = updateResult(parseStatus, curResult);
217+
ParseStatus cur_status = checkBuffer(parseResult);
218+
parseStatus = updateStatus(parseStatus, cur_status);
219219
} else {
220220
files = LIBC_NAMESPACE::strdup(files);
221221
for (char *file = LIBC_NAMESPACE::strtok(files, ","); file != nullptr;
222222
file = LIBC_NAMESPACE::strtok(nullptr, ",")) {
223-
ParseStatus curResult = checkFile(file, parseResult);
224-
parseStatus = updateResult(parseStatus, curResult);
223+
ParseStatus cur_status = checkFile(file, parseResult);
224+
parseStatus = updateStatus(parseStatus, cur_status);
225225
}
226226
}
227227

0 commit comments

Comments
 (0)