Skip to content

Commit b7f8f3f

Browse files
committed
Implement feedback from David
1 parent e1c02b8 commit b7f8f3f

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,6 @@ static uint32_t g_d31_invalidates[] = {fpu_v31, fpu_s31, LLDB_INVALID_REGNUM};
545545
KIND_ALL_INVALID, nullptr, nullptr, nullptr, \
546546
}
547547

548-
// Used to define tpidr as a generic tp register
549548
#define DEFINE_EXTENSION_REG_GENERIC(reg, generic_kind) \
550549
{ \
551550
#reg, nullptr, 8, 0, lldb::eEncodingUint, lldb::eFormatHex, \

lldb/test/API/linux/aarch64/tls_registers/TestAArch64LinuxTLSRegisters.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ def check_registers(self, registers, values):
5353
tls_reg.IsValid(), "{} register not found.".format(register)
5454
)
5555
self.assertEqual(tls_reg.GetValueAsUnsigned(), values[register])
56+
if register == "tpidr":
57+
self.expect("reg read tp", substrs=[hex(values[register])])
5658

5759
def check_tls_reg(self, registers):
5860
self.setup(registers)
@@ -93,8 +95,6 @@ def check_tls_reg(self, registers):
9395
for register in registers:
9496
self.expect("p {}_was_set".format(register), substrs=["true"])
9597

96-
self.expect("reg read tp", substrs=[hex(set_values["tpidr"])])
97-
9898
@skipUnlessArch("aarch64")
9999
@skipUnlessPlatform(["linux"])
100100
def test_tls_no_sme(self):

0 commit comments

Comments
 (0)