[GitHub][CI] Fix PR comment from boomanaiden154

Author: vbvictor

.github/workflows/pr-code-lint.yml

@@ -58,24 +58,21 @@ jobs:
           sparse-checkout-cone-mode: false
           path: code-lint-tools
 
-      - uses: actions/setup-python@v5
-        id: setup_python
+      - name: Install python
+        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
         with:
           python-version: '3.12'
-      
-      - name: Install dependencies
-        run: |
-          python3 -m venv .venv
-          source .venv/bin/activate
-          python3 -m pip install -r code-lint-tools/llvm/utils/git/requirements_linting.txt
+
+      - name: Install python dependencies
+        run: python3 -m pip install -r code-lint-tools/llvm/utils/git/requirements_linting.txt
 
       - name: Install clang-tidy
         uses: aminya/setup-cpp@17c11551771948abc5752bbf3183482567c7caf0 # v1.1.1
         with:
           clang-tidy: 20.1.8
 
       # FIXME: create special mapping for 'gen' targets, for now build predefined set
-      - name: Configure and Build
+      - name: Configure and CodeGen
         run: |
           git config --global --add safe.directory '*'
 
@@ -107,7 +104,6 @@ jobs:
           GITHUB_PR_NUMBER: ${{ github.event.pull_request.number }}
           CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
         run: |
-          source .venv/bin/activate
           echo "[]" > comments &&
           python3 ./code-lint-tools/llvm/utils/git/code-lint-helper.py \
             --token ${{ secrets.GITHUB_TOKEN }} \

llvm/utils/git/code-lint-helper.py

@@ -7,14 +7,8 @@
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 #
 # ==-------------------------------------------------------------------------==#
+"""A helper script to run clang-tidy linter in GitHub actions
 
-import argparse
-import os
-import subprocess
-import sys
-from typing import List, Optional
-
-"""
 This script is run by GitHub actions to ensure that the code in PR's conform to
 the coding style of LLVM. The canonical source of this script is in the LLVM
 source tree under llvm/utils/git.
@@ -23,6 +17,11 @@
 https://llvm.org/docs/CodingStandards.html
 """
 
+import argparse
+import os
+import subprocess
+from typing import List, Optional
+
 
 class LintArgs:
     start_rev: str = None
@@ -54,7 +53,7 @@ def __init__(self, args: argparse.Namespace = None) -> None:
 def get_instructions(cpp_files: List[str]) -> str:
     files_str = " ".join(cpp_files)
     return f"""
-git diff -U0 origin/main..HEAD -- {files_str} |
+git diff -U0 origin/main...HEAD -- {files_str} |
 python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py \\
   -path build -p1 -quiet"""
 
@@ -87,8 +86,8 @@ def clean_clang_tidy_output(output: str) -> Optional[str]:
     return None
 
 
+# TODO: Add more rules when enabling other projects to use clang-tidy in CI.
 def should_lint_file(filepath: str) -> bool:
-    # For add other paths/files to this function
     return filepath.startswith("clang-tools-extra/clang-tidy/")
 
 
@@ -106,16 +105,6 @@ def filter_changed_files(changed_files: List[str]) -> List[str]:
     return filtered_files
 
 
-def has_clang_tidy(clang_tidy_binary: str) -> bool:
-    cmd = [clang_tidy_binary, "--version"]
-    proc = None
-    try:
-        proc = subprocess.run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-    except:
-        return False
-    return proc.returncode == 0
-
-
 def create_comment_text(warning: str, cpp_files: List[str]) -> str:
     instructions = get_instructions(cpp_files)
     return f"""
@@ -181,7 +170,7 @@ def run_clang_tidy(changed_files: List[str], args: LintArgs) -> Optional[str]:
         "git",
         "diff",
         "-U0",
-        f"{args.start_rev}..{args.end_rev}",
+        f"{args.start_rev}...{args.end_rev}",
         "--",
     ] + changed_files
 
@@ -315,11 +304,6 @@ def run_linter(changed_files: List[str], args: LintArgs) -> tuple[bool, Optional
     if args.verbose:
         print(f"got changed files: {changed_files}")
 
-    # Check for clang-tidy tool
-    if not has_clang_tidy(args.clang_tidy_binary):
-        print("Couldn't find C/C++ code linter: clang-tidy")
-        sys.exit(1)
-
     if args.verbose:
         print("running linter clang-tidy")