Skip to content

Commit b836db3

Browse files
committed
Update comment per review suggestion.
1 parent 33ad0eb commit b836db3

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1187,12 +1187,9 @@ DWARFUnit::determineStringOffsetsTableContributionDWO(DWARFDataExtractor &DA) {
11871187
if (getVersion() >= 5) {
11881188
if (DA.getData().data() == nullptr)
11891189
return std::nullopt;
1190-
// For .dwo files, the section contribution for the .debug_str_offsets
1191-
// points to the string offsets table header. Decode the format from this
1192-
// data as llvm-dwp has been modified to be able to emit a
1193-
// .debug_str_offsets table as DWARF64 even if the compile unit is DWARF32.
1194-
// This allows .dwp files to have string tables that exceed UINT32_MAX in
1195-
// size.
1190+
// FYI: The .debug_str_offsets.dwo section may use DWARF64 even when the
1191+
// rest of the file uses DWARF32, so respect whichever encoding the
1192+
// header/length uses.
11961193
uint64_t Length = 0;
11971194
DwarfFormat Format = dwarf::DwarfFormat::DWARF32;
11981195
std::tie(Length, Format) = DA.getInitialLength(&Offset);

0 commit comments

Comments
 (0)