Skip to content

Commit b8502f4

Browse files
Review comment v1.0
1 parent a60b209 commit b8502f4

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

mlir/lib/Dialect/Linalg/Utils/Utils.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -461,10 +461,10 @@ class ConvMatcherBuilder {
461461
*strides = SmallVector<int64_t>(spatialRank, 1);
462462
}
463463

464-
/// Get affine dimension expression for dimension i.
464+
/// Get affine dimension expression for dimension `i`.
465465
AffineExpr dim(unsigned i) { return getAffineDimExpr(i, ctx); }
466466

467-
/// Build strided expression: base * stride[idx] + kernel * dilation[idx]
467+
/// Build strided expression: base * stride[idx] + kernel * dilation[idx].
468468
AffineExpr strided(AffineExpr base, AffineExpr kernel, unsigned idx) {
469469
return base * (*strides)[idx] + kernel * (*dilations)[idx];
470470
}
@@ -480,8 +480,7 @@ class ConvMatcherBuilder {
480480
return *this;
481481
}
482482

483-
/// Match expected indexing maps layout.
484-
/// Returns *this for method chaining.
483+
/// Match expected indexing maps layout. Returns *this for method chaining.
485484
ConvMatcherBuilder &expectMaps(ArrayRef<ArrayRef<AffineExpr>> maps) {
486485
if (matched)
487486
matched = convLayoutMatches(maps, indexingMaps, ctx);
@@ -512,9 +511,9 @@ class ConvMatcherBuilder {
512511
}
513512
};
514513

515-
// ---------------------------------------------
514+
//===----------------------------------------------------------------------===//
516515
// Matchers for specific convolution operation.
517-
// ---------------------------------------------
516+
//===----------------------------------------------------------------------===//
518517

519518
// #inputMap = affine_map<(W, w) -> (W + w)>
520519
// #filterMap = affine_map<(W, w) -> (w)>

0 commit comments

Comments
 (0)