nit fixes

Author: lfrenot

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

@@ -76,7 +76,7 @@ class LLVM_IntArithmeticOpWithOverflowFlag<string mnemonic, string instName,
     "$res = builder.Create" # instName #
     "($lhs, $rhs, /*Name=*/\"\", op.hasNoUnsignedWrap(), op.hasNoSignedWrap());";
 }
-class LLVM_IntArithmeticOpWithIsExact<string mnemonic, string instName,
+class LLVM_IntArithmeticOpWithExactFlag<string mnemonic, string instName,
                                    list<Trait> traits = []> :
     LLVM_ArithmeticOpBase<AnySignlessInteger, mnemonic, instName,
     !listconcat([DeclareOpInterfaceMethods<ExactFlagInterface>], traits)> {
@@ -134,8 +134,8 @@ def LLVM_AddOp : LLVM_IntArithmeticOpWithOverflowFlag<"add", "Add",
 def LLVM_SubOp : LLVM_IntArithmeticOpWithOverflowFlag<"sub", "Sub", []>;
 def LLVM_MulOp : LLVM_IntArithmeticOpWithOverflowFlag<"mul", "Mul",
     [Commutative]>;
-def LLVM_UDivOp : LLVM_IntArithmeticOpWithIsExact<"udiv", "UDiv">;
-def LLVM_SDivOp : LLVM_IntArithmeticOpWithIsExact<"sdiv", "SDiv">;
+def LLVM_UDivOp : LLVM_IntArithmeticOpWithExactFlag<"udiv", "UDiv">;
+def LLVM_SDivOp : LLVM_IntArithmeticOpWithExactFlag<"sdiv", "SDiv">;
 def LLVM_URemOp : LLVM_IntArithmeticOp<"urem", "URem">;
 def LLVM_SRemOp : LLVM_IntArithmeticOp<"srem", "SRem">;
 def LLVM_AndOp : LLVM_IntArithmeticOp<"and", "And">;
@@ -146,8 +146,8 @@ def LLVM_XOrOp : LLVM_IntArithmeticOp<"xor", "Xor">;
 def LLVM_ShlOp : LLVM_IntArithmeticOpWithOverflowFlag<"shl", "Shl", []> {
   let hasFolder = 1;
 }
-def LLVM_LShrOp : LLVM_IntArithmeticOpWithIsExact<"lshr", "LShr">;
-def LLVM_AShrOp : LLVM_IntArithmeticOpWithIsExact<"ashr", "AShr">;
+def LLVM_LShrOp : LLVM_IntArithmeticOpWithExactFlag<"lshr", "LShr">;
+def LLVM_AShrOp : LLVM_IntArithmeticOpWithExactFlag<"ashr", "AShr">;
 
 // Base class for compare operations. A compare operation takes two operands
 // of the same type and returns a boolean result. If the operands are

mlir/lib/Target/LLVMIR/ModuleImport.cpp

@@ -686,9 +686,7 @@ void ModuleImport::setIntegerOverflowFlags(llvm::Instruction *inst,
 void ModuleImport::setExactFlag(llvm::Instruction *inst, Operation *op) const {
   auto iface = cast<ExactFlagInterface>(op);
 
-  bool value = inst->isExact();
-
-  iface.setIsExact(value);
+  iface.setIsExact(inst->isExact());
 }
 
 void ModuleImport::setFastmathFlagsAttr(llvm::Instruction *inst,

mlir/test/Dialect/LLVMIR/roundtrip.mlir

@@ -49,7 +49,7 @@ func.func @ops(%arg0: i32, %arg1: f32,
   %mul_flag = llvm.mul %arg0, %arg0 overflow<nsw, nuw> : i32
   %shl_flag = llvm.shl %arg0, %arg0 overflow<nuw, nsw> : i32
 
-// Integer exact
+// Integer exact flag.
 // CHECK: {{.*}} = llvm.sdiv exact %[[I32]], %[[I32]] : i32
 // CHECK: {{.*}} = llvm.udiv exact %[[I32]], %[[I32]] : i32
 // CHECK: {{.*}} = llvm.ashr exact %[[I32]], %[[I32]] : i32