Skip to content

Commit b92a88b

Browse files
[lldb] Don't call FixDataAddress when reading fp in ReadGPRValue
Based on testing on processors that use pointer metadata, and with all the work done to delay calls to FixDataAddress, this is no longer necessary. Note that, with debugserver in particular, this is an NFC change: the code path here is for frame zero, and debugserver will strip metadata when reading fp from frame zero anyway.
1 parent 31e43e2 commit b92a88b

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

lldb/source/Target/RegisterContextUnwind.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2228,9 +2228,6 @@ bool RegisterContextUnwind::ReadGPRValue(lldb::RegisterKind register_kind,
22282228
if (generic_regnum == LLDB_REGNUM_GENERIC_PC ||
22292229
generic_regnum == LLDB_REGNUM_GENERIC_RA)
22302230
value = abi_sp->FixCodeAddress(value);
2231-
if (generic_regnum == LLDB_REGNUM_GENERIC_SP ||
2232-
generic_regnum == LLDB_REGNUM_GENERIC_FP)
2233-
value = abi_sp->FixDataAddress(value);
22342231
}
22352232
return true;
22362233
}

0 commit comments

Comments
 (0)