Address feedback

Author: boomanaiden154

clang/docs/CMakeLists.txt

@@ -144,13 +144,17 @@ if (LLVM_ENABLE_SPHINX)
     gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs ../include/clang/Driver/ClangOptionDocs.td "${docs_targets}")
 
     set (dump_format_style ${CLANG_SOURCE_DIR}/docs/tools/dump_format_style.py)
-    add_custom_target(clang-format-style-options
-      COMMAND "${Python3_EXECUTABLE}" "${dump_format_style}"
-      WORKING_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}"
+    add_custom_command(OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/ClangFormatStyleOptions.rst"
+      COMMAND "${Python3_EXECUTABLE}" "${dump_format_style}" "${CMAKE_CURRENT_BINARY_DIR}/ClangFormatStyleOptions.rst"
+      WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
       DEPENDS "${CLANG_SOURCE_DIR}/include/clang/Format/Format.h"
               "${CLANG_SOURCE_DIR}/include/clang/Tooling/Inclusions/IncludeStyle.h"
+              "${CLANG_SOURCE_DIR}/docs/ClangFormatStyleOptions.rst.template"
               "${dump_format_style}"
-              copy-clang-rst-docs
+    )
+
+    add_custom_target(clang-format-style-options
+      DEPENDS "${CMAKE_CURRENT_BINARY_DIR}/ClangFormatStyleOptions.rst"
     )
 
     foreach(target ${docs_targets})

clang/docs/ClangFormatStyleOptions.rst renamed to clang/docs/ClangFormatStyleOptions.rst.template

@@ -15,7 +15,7 @@
 INCLUDE_STYLE_FILE = os.path.join(
     CLANG_DIR, "include/clang/Tooling/Inclusions/IncludeStyle.h"
 )
-DOC_FILE = "ClangFormatStyleOptions.rst"
+DOC_FILE = "ClangFormatStyleOptions.rst.template"
 
 PLURALS_FILE = os.path.join(os.path.dirname(__file__), "plurals.txt")
 
@@ -487,5 +487,5 @@ class State:
 
 contents = substitute(contents, "FORMAT_STYLE_OPTIONS", options_text)
 
-with open(DOC_FILE, "wb") as output:
+with open(sys.argv[1], "wb") as output:
     output.write(contents.encode())