annotation and format

Author: Sockke

llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h

@@ -143,6 +143,8 @@ class DWARFUnitVector final : public SmallVector<std::unique_ptr<DWARFUnit>, 1>
       decltype(make_filter_range(std::declval<iterator_range>(), isCompileUnit));
 
   LLVM_ABI DWARFUnit *getUnitForOffset(uint64_t Offset) const;
+  /// Returns the Unit from the .debug_info or .debug_types section by the index
+  /// entry.
   LLVM_ABI DWARFUnit *
   getUnitForIndexEntry(const DWARFUnitIndex::Entry &E, DWARFSectionKind Sec,
                        const DWARFSection *Section = nullptr);

llvm/lib/DebugInfo/DWARF/DWARFContext.cpp

@@ -1345,10 +1345,10 @@ DWARFTypeUnit *DWARFContext::getTypeUnitForHash(uint64_t Hash, bool IsDWO) {
   DWARFUnitVector &DWOUnits = State->getDWOUnits();
   if (const auto &TUI = getTUIndex()) {
     if (const auto *R = TUI.getFromHash(Hash)) {
-      if (TUI.getVersion() >= 5)
+      if (TUI.getVersion() >= 5) {
         return dyn_cast_or_null<DWARFTypeUnit>(
             DWOUnits.getUnitForIndexEntry(*R, DW_SECT_INFO));
-      else {
+      } else {
         DWARFUnit *TypesUnit = nullptr;
         getDWARFObj().forEachTypesDWOSections([&](const DWARFSection &S) {
           if (!TypesUnit)

llvm/test/tools/llvm-dwarfdump/X86/type_units_split_dwp_v4.s

@@ -1,3 +1,6 @@
+# This test uses TU index for type parsing in dwp and makes sure the DWARF4 type is
+# successfully retrieved.
+
 # RUN: llvm-mc %s --split-dwarf-file=test.dwo -filetype obj -triple x86_64 -o test.o
 # RUN: llvm-dwp -e test.o -o test.dwp
 # RUN: llvm-dwarfdump test.dwp | FileCheck %s