Skip to content

Commit bacd891

Browse files
committed
[LAA] Strip outdated comment in isDependent (NFC)
The comment has been outdated since 87ddd3a ([LAA] Rename and fix semantics of MaxSafeDepDistBytes to MinDepDistBytes).
1 parent 67e73ba commit bacd891

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

llvm/lib/Analysis/LoopAccessAnalysis.cpp

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2280,22 +2280,6 @@ MemoryDepChecker::isDependent(const MemAccessInfo &A, unsigned AIdx,
22802280
return Dependence::Backward;
22812281
}
22822282

2283-
// Positive distance bigger than max vectorization factor.
2284-
// FIXME: Should use max factor instead of max distance in bytes, which could
2285-
// not handle different types.
2286-
// E.g. Assume one char is 1 byte in memory and one int is 4 bytes.
2287-
// void foo (int *A, char *B) {
2288-
// for (unsigned i = 0; i < 1024; i++) {
2289-
// A[i+2] = A[i] + 1;
2290-
// B[i+2] = B[i] + 1;
2291-
// }
2292-
// }
2293-
//
2294-
// This case is currently unsafe according to the max safe distance. If we
2295-
// analyze the two accesses on array B, the max safe dependence distance
2296-
// is 2. Then we analyze the accesses on array A, the minimum distance needed
2297-
// is 8, which is less than 2 and forbidden vectorization, But actually
2298-
// both A and B could be vectorized by 2 iterations.
22992283
MinDepDistBytes =
23002284
std::min(static_cast<uint64_t>(MinDistance), MinDepDistBytes);
23012285

0 commit comments

Comments
 (0)