address pr feedback

Author: farzonl

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -12356,7 +12356,7 @@ def err_builtin_invalid_arg_type: Error <
   "an unsigned integer|"
   "an 'int'|"
   "a vector of floating points|"
-  "a vector of integers or floating points}1 (was %2)">;
+  "a vector of arithmetic element type}1 (was %2)">;
 
 def err_builtin_matrix_disabled: Error<
   "matrix types extension is disabled. Pass -fenable-matrix to enable it">;

clang/lib/AST/ByteCode/InterpBuiltin.cpp

@@ -7,7 +7,6 @@
 //===----------------------------------------------------------------------===//
 #include "../ExprConstShared.h"
 #include "Boolean.h"
-#include "ByteCode/Floating.h"
 #include "Compiler.h"
 #include "EvalEmitter.h"
 #include "Interp.h"

clang/lib/CodeGen/CGBuiltin.cpp

@@ -4283,7 +4283,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
     if (E->getArg(0)->getType()->hasFloatingRepresentation()) {
       Value *X = EmitScalarExpr(E->getArg(0));
       auto EltTy = X->getType()->getScalarType();
-      Value *Seed = ConstantFP::get(EltTy, 0);
+      Value *Seed = ConstantFP::get(EltTy, -0.0);
       return RValue::get(Builder.CreateIntrinsic(
           /*ReturnType=*/EltTy, llvm::Intrinsic::vector_reduce_fadd,
           ArrayRef<Value *>{Seed, X}, nullptr, "rdx.fadd"));
@@ -4296,7 +4296,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
     if (E->getArg(0)->getType()->hasFloatingRepresentation()) {
       Value *X = EmitScalarExpr(E->getArg(0));
       auto EltTy = X->getType()->getScalarType();
-      Value *Seed = ConstantFP::get(EltTy, 0);
+      Value *Seed = ConstantFP::get(EltTy, 1.0);
       return RValue::get(Builder.CreateIntrinsic(
           /*ReturnType=*/EltTy, llvm::Intrinsic::vector_reduce_fmul,
           ArrayRef<Value *>{Seed, X}, nullptr, "rdx.fmul"));

clang/test/CodeGen/builtins-reduction-math.c

@@ -64,11 +64,11 @@ void test_builtin_reduce_min(float4 vf1, si8 vi1, u4 vu1) {
 
 void test_builtin_reduce_addf(float4 vf4, double4 vd4) {          
   // CHECK:      [[VF4:%.+]] = load <4 x float>, ptr %vf4.addr, align 16
-  // CHECK-NEXT: call float @llvm.vector.reduce.fadd.v4f32(float 0.000000e+00, <4 x float> [[VF4]])
+  // CHECK-NEXT: call float @llvm.vector.reduce.fadd.v4f32(float -0.000000e+00, <4 x float> [[VF4]])
   float r2 = __builtin_reduce_add(vf4);
 
   // CHECK:      [[VD4:%.+]] = load <4 x double>, ptr %vd4.addr, align 16
-  // CHECK-NEXT: call double @llvm.vector.reduce.fadd.v4f64(double 0.000000e+00, <4 x double> [[VD4]])
+  // CHECK-NEXT: call double @llvm.vector.reduce.fadd.v4f64(double -0.000000e+00, <4 x double> [[VD4]])
   double r3 = __builtin_reduce_add(vd4);
 }
 
@@ -96,11 +96,11 @@ void test_builtin_reduce_add(si8 vi1, u4 vu1) {
 
 void test_builtin_reduce_mulf(float4 vf4, double4 vd4) {          
   // CHECK:      [[VF4:%.+]] = load <4 x float>, ptr %vf4.addr, align 16
-  // CHECK-NEXT: call float @llvm.vector.reduce.fmul.v4f32(float 0.000000e+00, <4 x float> [[VF4]])
+  // CHECK-NEXT: call float @llvm.vector.reduce.fmul.v4f32(float 1.000000e+00, <4 x float> [[VF4]])
   float r2 = __builtin_reduce_mul(vf4);
 
   // CHECK:      [[VD4:%.+]] = load <4 x double>, ptr %vd4.addr, align 16
-  // CHECK-NEXT: call double @llvm.vector.reduce.fmul.v4f64(double 0.000000e+00, <4 x double> [[VD4]])
+  // CHECK-NEXT: call double @llvm.vector.reduce.fmul.v4f64(double 1.000000e+00, <4 x double> [[VD4]])
   double r3 = __builtin_reduce_mul(vd4);
 }
 

clang/test/Sema/builtins-reduction-math.c

@@ -47,10 +47,10 @@ void test_builtin_reduce_add(int i, float f, int3 iv) {
   // expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
 
   i = __builtin_reduce_add(i);
-  // expected-error@-1 {{1st argument must be a vector of integers or floating points (was 'int')}}
+  // expected-error@-1 {{1st argument must be a vector of arithmetic element type (was 'int')}}
 
   f = __builtin_reduce_add(f);
-  // expected-error@-1 {{1st argument must be a vector of integers or floating points (was 'float')}}
+  // expected-error@-1 {{1st argument must be a vector of arithmetic element type (was 'float')}}
 }
 
 void test_builtin_reduce_mul(int i, float f, int3 iv) {
@@ -64,10 +64,10 @@ void test_builtin_reduce_mul(int i, float f, int3 iv) {
   // expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
 
   i = __builtin_reduce_mul(i);
-  // expected-error@-1 {{1st argument must be a vector of integers or floating points (was 'int')}}
+  // expected-error@-1 {{1st argument must be a vector of arithmetic element type (was 'int')}}
 
   f = __builtin_reduce_mul(f);
-  // expected-error@-1 {{1st argument must be a vector of integers or floating points (was 'float')}}
+  // expected-error@-1 {{1st argument must be a vector of arithmetic element type (was 'float')}}
 }
 
 void test_builtin_reduce_xor(int i, float4 v, int3 iv) {