Skip to content

Commit bae926e

Browse files
[Github][CI] Make premerge upload results on Linux and Windows
Now that the issue-write workflow can support writing comments from multiple files, make the premerge workflow write out comments from both x86_64 Linux and Windows. AArch64 Linux right now is left out as the premerge advisor does not currently support it. Pull Request: #170414
1 parent e362d6f commit bae926e

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

.ci/premerge_advisor_explain.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,8 @@ def main(
129129
# If the job succeeds and there is not an existing comment, we
130130
# should not write one to reduce noise.
131131
comments = []
132-
with open("comments", "w") as comment_file_handle:
132+
comments_file_name = f"comments-{platform.system()}-{platform.machine()}"
133+
with open(comments_file_name, "w") as comment_file_handle:
133134
json.dump(comments, comment_file_handle)
134135

135136

.github/workflows/premerge.yaml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ jobs:
124124
if: ${{ always() && !startsWith(matrix.runs-on, 'depot-ubuntu-24.04-arm') }}
125125
continue-on-error: true
126126
with:
127-
name: workflow-args
127+
name: workflow-args-x86-linux
128128
path: |
129-
comments
129+
comments-Linux-x86_64
130130
131131
premerge-checks-windows:
132132
name: Build and Test Windows
@@ -185,6 +185,14 @@ jobs:
185185
path: artifacts/
186186
retention-days: 5
187187
include-hidden-files: 'true'
188+
- name: Upload Comment
189+
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
190+
if: always()
191+
continue-on-error: true
192+
with:
193+
name: workflow-args-windows
194+
path: |
195+
comments-Windows-x86_64
188196
189197
premerge-check-macos:
190198
name: MacOS Premerge Checks

0 commit comments

Comments
 (0)