Skip to content

Commit bb0e213

Browse files
committed
Rename llvmPrivateVars to llvmPrivateVarGEPs
1 parent ffec9f4 commit bb0e213

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1781,8 +1781,8 @@ class TaskContextStructManager {
17811781
/// De-allocate the task context structure.
17821782
void freeStructPtr();
17831783

1784-
MutableArrayRef<llvm::Value *> getLLVMPrivateVars() {
1785-
return llvmPrivateVars;
1784+
MutableArrayRef<llvm::Value *> getLLVMPrivateVarGEPs() {
1785+
return llvmPrivateVarGEPs;
17861786
}
17871787

17881788
llvm::Value *getStructPtr() { return structPtr; }
@@ -1797,7 +1797,7 @@ class TaskContextStructManager {
17971797

17981798
/// LLVM values for each private variable, or null if that private variable is
17991799
/// not included in the task context structure
1800-
SmallVector<llvm::Value *> llvmPrivateVars;
1800+
SmallVector<llvm::Value *> llvmPrivateVarGEPs;
18011801

18021802
/// A pointer to the structure containing context for this task.
18031803
llvm::Value *structPtr = nullptr;
@@ -1841,19 +1841,19 @@ void TaskContextStructManager::createGEPsToPrivateVars() {
18411841
}
18421842

18431843
// Create GEPs for each struct member
1844-
llvmPrivateVars.clear();
1845-
llvmPrivateVars.reserve(privateDecls.size());
1844+
llvmPrivateVarGEPs.clear();
1845+
llvmPrivateVarGEPs.reserve(privateDecls.size());
18461846
llvm::Value *zero = builder.getInt32(0);
18471847
unsigned i = 0;
18481848
for (auto privDecl : privateDecls) {
18491849
if (!privDecl.readsFromMold()) {
18501850
// Handle this inside of the task so we don't pass unnessecary vars in
1851-
llvmPrivateVars.push_back(nullptr);
1851+
llvmPrivateVarGEPs.push_back(nullptr);
18521852
continue;
18531853
}
18541854
llvm::Value *iVal = builder.getInt32(i);
18551855
llvm::Value *gep = builder.CreateGEP(structTy, structPtr, {zero, iVal});
1856-
llvmPrivateVars.push_back(gep);
1856+
llvmPrivateVarGEPs.push_back(gep);
18571857
i += 1;
18581858
}
18591859
}
@@ -1948,7 +1948,7 @@ convertOmpTaskOp(omp::TaskOp taskOp, llvm::IRBuilderBase &builder,
19481948

19491949
for (auto [privDecl, mlirPrivVar, blockArg, llvmPrivateVarAlloc] :
19501950
llvm::zip_equal(privateDecls, mlirPrivateVars, privateBlockArgs,
1951-
taskStructMgr.getLLVMPrivateVars())) {
1951+
taskStructMgr.getLLVMPrivateVarGEPs())) {
19521952
if (!privDecl.readsFromMold())
19531953
// to be handled inside the task
19541954
continue;
@@ -1987,7 +1987,7 @@ convertOmpTaskOp(omp::TaskOp taskOp, llvm::IRBuilderBase &builder,
19871987
// firstprivate copy region
19881988
setInsertPointForPossiblyEmptyBlock(builder, copyBlock);
19891989
if (failed(copyFirstPrivateVars(builder, moduleTranslation, mlirPrivateVars,
1990-
taskStructMgr.getLLVMPrivateVars(),
1990+
taskStructMgr.getLLVMPrivateVarGEPs(),
19911991
privateDecls)))
19921992
return llvm::failure();
19931993

@@ -2030,7 +2030,7 @@ convertOmpTaskOp(omp::TaskOp taskOp, llvm::IRBuilderBase &builder,
20302030
// Find and map the addresses of each variable within the task context
20312031
// structure
20322032
taskStructMgr.createGEPsToPrivateVars();
2033-
llvm::copy(taskStructMgr.getLLVMPrivateVars(),
2033+
llvm::copy(taskStructMgr.getLLVMPrivateVarGEPs(),
20342034
std::back_inserter(llvmPrivateVars));
20352035
for (auto [blockArg, llvmPrivateVar] :
20362036
llvm::zip_equal(privateBlockArgs, llvmPrivateVars)) {

0 commit comments

Comments
 (0)