Add proper tests for on-disk and in-memory files

Author: DeinAlptraum

clang/bindings/python/tests/cindex/test_file.py

@@ -19,74 +19,54 @@ def test_file(self):
         self.assertEqual(repr(file), "<File: t.c>")
 
     def test_file_eq(self):
-        path = os.path.join(inputs_dir, "hello.cpp")
-        header_path = os.path.join(inputs_dir, "header3.h")
+        path = os.path.join(inputs_dir, "testfile.c")
+        path_a = os.path.join(inputs_dir, "a.inc")
+        path_b = os.path.join(inputs_dir, "b.inc")
         tu = TranslationUnit.from_source(path)
-        file1 = File.from_name(tu, path)
-        file2 = File.from_name(tu, header_path)
-        file2_2 = File.from_name(tu, header_path)
-
-        self.assertEqual(file1, file1)
-        self.assertEqual(file2, file2_2)
-        self.assertNotEqual(file1, file2)
-        self.assertNotEqual(file1, "t.c")
-
-    def test_file_eq_failing(self):
-        index = Index.create()
-        tu = index.parse(
-            "t.c",
-            unsaved_files=[
-                ("t.c", "int a = 729;"),
-                ("s.c", "int a = 729;"),
-            ],
-        )
-        file1 = File.from_name(tu, "t.c")
-        file2 = File.from_name(tu, "s.c")
-        # FIXME: These files are not supposed to be equal
-        self.assertEqual(file1, file2)
+        print(tu.spelling, tu.cursor.spelling)
+        main_file = File.from_name(tu, path)
+        a_file = File.from_name(tu, path_a)
+        a_file2 = File.from_name(tu, path_a)
+        b_file = File.from_name(tu, path_b)
 
-    def test_file_eq_failing_2(self):
-        index = Index.create()
-        tu = index.parse(
-            "t.c",
-            unsaved_files=[
-                ("t.c", "int a = 729;"),
-                ("s.c", "int a = 728;"),
-            ],
-        )
-        file1 = File.from_name(tu, "t.c")
-        file2 = File.from_name(tu, "s.c")
-        # FIXME: These files are not supposed to be equal
-        self.assertEqual(file1, file2)
+        self.assertEqual(a_file, a_file2)
+        self.assertNotEqual(a_file, b_file)
+        self.assertNotEqual(main_file, a_file)
+        self.assertNotEqual(main_file, b_file)
+        self.assertNotEqual(main_file, "t.c")
 
-    def test_file_eq_failing_3(self):
-        index = Index.create()
-        tu = index.parse(
-            "t.c",
+    def test_file_eq_in_memory(self):
+        tu = TranslationUnit.from_source(
+            "testfile.c",
             unsaved_files=[
-                ("t.c", '#include "a.c"\n#include "b.c";'),
-                ("a.c", "int a = 729;"),
-                ("b.c", "int b = 729;"),
+                (
+                    "testfile.c",
+                    """
+int a[] = { 
+    #include "a.inc"
+};
+int b[] = { 
+    #include "b.inc"
+};
+""",
+                ),
+                ("a.inc", "1,2,3"),
+                ("b.inc", "1,2,3"),
             ],
         )
-        file1 = File.from_name(tu, "t.c")
-        file2 = File.from_name(tu, "a.c")
-        file3 = File.from_name(tu, "b.c")
-        # FIXME: These files are not supposed to be equal
-        self.assertEqual(file2, file3)
-        self.assertEqual(file1, file2)
-        self.assertEqual(file1, file3)
 
-    def test_file_eq_failing_4(self):
         path = os.path.join(inputs_dir, "testfile.c")
         path_a = os.path.join(inputs_dir, "a.inc")
         path_b = os.path.join(inputs_dir, "b.inc")
         tu = TranslationUnit.from_source(path)
         print(tu.spelling, tu.cursor.spelling)
-        file1 = File.from_name(tu, path)
-        file2 = File.from_name(tu, path_a)
-        file3 = File.from_name(tu, path_b)
-        # FIXME: These files are not supposed to be equal
-        self.assertEqual(file2, file3)
-        self.assertEqual(file1, file2)
-        self.assertEqual(file1, file3)
+        main_file = File.from_name(tu, path)
+        a_file = File.from_name(tu, path_a)
+        a_file2 = File.from_name(tu, path_a)
+        b_file = File.from_name(tu, path_b)
+
+        self.assertEqual(a_file, a_file2)
+        self.assertNotEqual(a_file, b_file)
+        self.assertNotEqual(main_file, a_file)
+        self.assertNotEqual(main_file, b_file)
+        self.assertNotEqual(main_file, "a.inc")