Address review feedback

Author: andykaylor

clang/include/clang/CIR/Dialect/IR/CIRAttrs.td

@@ -280,17 +280,16 @@ def ConstPtrAttr : CIR_Attr<"ConstPtr", "ptr", [TypedAttrInterface]> {
 // VisibilityAttr
 //===----------------------------------------------------------------------===//
 
-def VK_Default : I32EnumAttrCase<"Default", 1, "default">;
-def VK_Hidden : I32EnumAttrCase<"Hidden", 2, "hidden">;
-def VK_Protected : I32EnumAttrCase<"Protected", 3, "protected">;
-
-def VisibilityKind : I32EnumAttr<"VisibilityKind", "C/C++ visibility", [
-  VK_Default, VK_Hidden, VK_Protected
+def CIR_VisibilityKind : I32EnumAttr<"VisibilityKind", "C/C++ visibility", [
+  I32EnumAttrCase<"Default", 1, "default">,
+  I32EnumAttrCase<"Hidden", 2, "hidden">,
+  I32EnumAttrCase<"Protected", 3, "protected">
 ]> {
+  let genSpecializedAttr = 0;
   let cppNamespace = "::cir";
 }
 
-def VisibilityAttr : CIR_Attr<"Visibility", "visibility"> {
+def CIR_VisibilityAttr : CIR_Attr<"Visibility", "visibility"> {
   let summary = "Visibility attribute";
   let description = [{
     Visibility attributes.

clang/include/clang/CIR/Dialect/IR/CIROps.td

@@ -1653,7 +1653,7 @@ def GlobalOp : CIR_Op<"global",
   // necessary Symbol's interface in terms of linkage instead.
   let arguments = (ins SymbolNameAttr:$sym_name,
                        DefaultValuedAttr<
-                        VisibilityAttr,
+                        CIR_VisibilityAttr,
                         "VisibilityKind::Default"
                        >:$global_visibility,
                        OptionalAttr<StrAttr>:$sym_visibility,

clang/lib/CIR/CodeGen/CIRGenModule.cpp

@@ -1103,7 +1103,7 @@ static bool shouldAssumeDSOLocal(const CIRGenModule &cgm,
   assert(!cir::MissingFeatures::opGlobalDLLImportExport());
 
   const llvm::Triple &tt = cgm.getTriple();
-  const auto &cgOpts = cgm.getCodeGenOpts();
+  const CodeGenOptions &cgOpts = cgm.getCodeGenOpts();
   if (tt.isWindowsGNUEnvironment()) {
     // In MinGW, variables without DLLImport can still be automatically
     // imported from a DLL by the linker; don't mark variables that
@@ -1135,7 +1135,7 @@ static bool shouldAssumeDSOLocal(const CIRGenModule &cgm,
     return false;
 
   llvm::Reloc::Model rm = cgOpts.RelocationModel;
-  const auto &lOpts = cgm.getLangOpts();
+  const LangOptions &lOpts = cgm.getLangOpts();
   if (rm != llvm::Reloc::Static && !lOpts.PIE) {
     // On ELF, if -fno-semantic-interposition is specified and the target
     // supports local aliases, there will be neither CC1
@@ -1144,8 +1144,8 @@ static bool shouldAssumeDSOLocal(const CIRGenModule &cgm,
     // PLT indirection).
     if (!(isa<cir::FuncOp>(gv) && gv.canBenefitFromLocalAlias()))
       return false;
-    return !(cgm.getLangOpts().SemanticInterposition ||
-             cgm.getLangOpts().HalfNoSemanticInterposition);
+    return !(lOpts.SemanticInterposition ||
+             lOpts.HalfNoSemanticInterposition);
   }
 
   // A definition cannot be preempted from an executable.

clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

@@ -966,7 +966,7 @@ void CIRToLLVMGlobalOpLowering::setupRegionInitializedLLVMGlobalOp(
   const bool isConst = false;
   assert(!cir::MissingFeatures::addressSpace());
   const unsigned addrSpace = 0;
-  const auto isDsoLocal = op.getDsolocal();
+  const bool isDsoLocal = op.getDsolocal();
   assert(!cir::MissingFeatures::opGlobalThreadLocal());
   const bool isThreadLocal = false;
   const uint64_t alignment = op.getAlignment().value_or(0);
@@ -1020,7 +1020,7 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite(
   const bool isConst = false;
   assert(!cir::MissingFeatures::addressSpace());
   const unsigned addrSpace = 0;
-  const auto isDsoLocal = op.getDsolocal();
+  const bool isDsoLocal = op.getDsolocal();
   assert(!cir::MissingFeatures::opGlobalThreadLocal());
   const bool isThreadLocal = false;
   const uint64_t alignment = op.getAlignment().value_or(0);