remove uthe updateSectionPrefix helper method and unit test

Author: mingmingl-llvm

llvm/include/llvm/IR/GlobalObject.h

@@ -127,11 +127,6 @@ class GlobalObject : public GlobalValue {
   /// Set the section prefix for this global object.
   void setSectionPrefix(StringRef Prefix);
 
-  /// Update the section prefix, unless the existing prefix is the same as
-  /// `KeepPrefix`.
-  void updateSectionPrefix(StringRef Prefix,
-                           std::optional<StringRef> KeepPrefix = std::nullopt);
-
   /// Get the section prefix for this global object.
   std::optional<StringRef> getSectionPrefix() const;
 

llvm/lib/IR/Globals.cpp

@@ -293,17 +293,6 @@ void GlobalObject::setSectionPrefix(StringRef Prefix) {
               MDB.createGlobalObjectSectionPrefix(Prefix));
 }
 
-void GlobalObject::updateSectionPrefix(StringRef Prefix,
-                                       std::optional<StringRef> KeepPrefix) {
-  auto SectionPrefix = getSectionPrefix();
-  if (SectionPrefix && (*SectionPrefix == Prefix ||
-                        (KeepPrefix && *SectionPrefix == *KeepPrefix)))
-    return;
-
-  setSectionPrefix(Prefix);
-  return;
-}
-
 std::optional<StringRef> GlobalObject::getSectionPrefix() const {
   if (MDNode *MD = getMetadata(LLVMContext::MD_section_prefix)) {
     [[maybe_unused]] StringRef MDName =

llvm/unittests/IR/CMakeLists.txt

@@ -28,7 +28,6 @@ add_llvm_unittest(IRTests
   DominatorTreeBatchUpdatesTest.cpp
   DroppedVariableStatsIRTest.cpp
   FunctionTest.cpp
-  GlobalObjectTest.cpp
   PassBuilderCallbacksTest.cpp
   IRBuilderTest.cpp
   InstructionsTest.cpp