Addresses review comments.

Author: mordante

libcxx/test/libcxx/clang_tidy.gen.py

@@ -6,6 +6,7 @@
 #
 # ===----------------------------------------------------------------------===##
 
+
 # Run our custom libc++ clang-tidy checks on all public headers.
 
 # RUN: %{python} %s %{libcxx-dir}/utils
@@ -23,6 +24,9 @@
 
 // REQUIRES: has-clang-tidy
 
+// The frozen headers should not be updated to the latest libc++ style, so don't test.
+// UNSUPPORTED: FROZEN-CXX03-HEADERS-FIXME
+
 // The GCC compiler flags are not always compatible with clang-tidy.
 // UNSUPPORTED: gcc
 

libcxx/test/tools/clang_tidy_checks/robust_against_operator_ampersand.cpp

@@ -19,12 +19,9 @@
 namespace libcpp {
 robust_against_operator_ampersand::robust_against_operator_ampersand(
     llvm::StringRef name, clang::tidy::ClangTidyContext* context)
-    : clang::tidy::ClangTidyCheck(name, context), disabled_(!context->getLangOpts().CPlusPlus11) {}
+    : clang::tidy::ClangTidyCheck(name, context) {}
 
 void robust_against_operator_ampersand::registerMatchers(clang::ast_matchers::MatchFinder* finder) {
-  if (disabled_)
-    return;
-
   using namespace clang::ast_matchers;
   finder->addMatcher(
       cxxOperatorCallExpr(allOf(hasOperatorName("&"), argumentCountIs(1), isTypeDependent()),

libcxx/test/tools/clang_tidy_checks/robust_against_operator_ampersand.hpp

@@ -10,12 +10,6 @@
 
 namespace libcpp {
 class robust_against_operator_ampersand : public clang::tidy::ClangTidyCheck {
-  // At the moment libc++ is phasing out development on C++03.
-  // To avoid testing in C++03, this test is automatically disabled in C++03
-  // mode. (Doing this from the tests is a lot harder.)
-  // TODO Remove after dropping C++03 support.
-  bool disabled_;
-
 public:
   robust_against_operator_ampersand(llvm::StringRef, clang::tidy::ClangTidyContext*);
   void registerMatchers(clang::ast_matchers::MatchFinder*) override;