move BasicELFBuilder ctor and dtor to .cpp

Kyle Krueger · Kyle Krueger · commit bc927cea2b12 · 2025-08-19T23:00:52.000+02:00
diff --git a/llvm/lib/ObjCopy/ELF/ELFObject.cpp b/llvm/lib/ObjCopy/ELF/ELFObject.cpp
@@ -1307,6 +1307,9 @@ Error BasicELFBuilder::initSections() {
   return Error::success();
 }
 
+BasicELFBuilder::BasicELFBuilder() : Obj(std::make_unique<Object>()) {}
+BasicELFBuilder::~BasicELFBuilder() = default;
+
 void BinaryELFBuilder::addData(SymbolTableSection *SymTab) {
   auto Data = ArrayRef<uint8_t>(
       reinterpret_cast<const uint8_t *>(MemBuf->getBufferStart()),
diff --git a/llvm/lib/ObjCopy/ELF/ELFObject.h b/llvm/lib/ObjCopy/ELF/ELFObject.h
@@ -1059,7 +1059,8 @@ class BasicELFBuilder {
   Error initSections();
 
 public:
-  BasicELFBuilder() : Obj(std::make_unique<Object>()) {}
+  BasicELFBuilder();
+  ~BasicELFBuilder();
 };
 
 class BinaryELFBuilder : public BasicELFBuilder {

Original file line number	Diff line number	Diff line change
`@@ -1307,6 +1307,9 @@ Error BasicELFBuilder::initSections() {`
`1307`	`1307`	`return Error::success();`
`1308`	`1308`	`}`
`1309`	`1309`
	`1310`	`+BasicELFBuilder::BasicELFBuilder() : Obj(std::make_unique<Object>()) {}`
	`1311`	`+BasicELFBuilder::~BasicELFBuilder() = default;`
	`1312`	`+`
`1310`	`1313`	`void BinaryELFBuilder::addData(SymbolTableSection *SymTab) {`
`1311`	`1314`	`auto Data = ArrayRef<uint8_t>(`
`1312`	`1315`	`reinterpret_cast<const uint8_t *>(MemBuf->getBufferStart()),`